Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 vue-dot: Fix menus display in HeaderBar #1869

Merged
merged 1 commit into from
Mar 25, 2022

Conversation

deraw
Copy link
Member

@deraw deraw commented Mar 25, 2022

Description

Correction de l'affichage des menus dans le composant HeaderBar.

Playground

<template>
	<HeaderBar>
		<UserMenuBtn full-name="Édith Cartier">
			<VListItem
				v-for="(item, index) in items"
				:key="index"
			>
				<VListItemTitle>{{ item }}</VListItemTitle>
			</VListItem>
		</UserMenuBtn>
	</HeaderBar>
</template>

<script lang="ts">
	import Vue from 'vue';
	import Component from 'vue-class-component';

	@Component
	export default class HeaderBarDefaultSlot extends Vue {
		items = [
			'Profil',
			'Paramètres',
			'Administration'
		];
	}
</script>

Type de changement

  • Correction de bug

Checklist

  • Ma Pull Request pointe vers la bonne branche
  • Mon code suit le style de code du projet
  • J'ai effectué une review de mon propre code
  • J'ai commenté mon code, en particulier dans les parties difficiles à comprendre
  • J'ai apporté les modifications correspondantes à la documentation
  • Mes modifications ne génèrent aucun nouveau warning
  • J'ai ajouté des tests qui prouvent que mon correctif est efficace ou que ma fonctionnalité fonctionne
  • Les tests unitaires passent localement avec mes modifications
  • J'ai mis à jour le fichier Changelog

@codecov
Copy link

codecov bot commented Mar 25, 2022

Codecov Report

Merging #1869 (ee5ac1e) into dev (0714dbf) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               dev     #1869   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          178       178           
  Lines         1188      1188           
  Branches       157       157           
=========================================
  Hits          1188      1188           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0714dbf...ee5ac1e. Read the comment docs.

@deraw deraw merged commit 4051f0f into dev Mar 25, 2022
@deraw deraw deleted the vue-dot/fix/header-bar-overflow branch March 25, 2022 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant