Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎨 vue-dash: Improve code quality #1908

Merged
merged 1 commit into from
Apr 8, 2022

Conversation

deraw
Copy link
Member

@deraw deraw commented Apr 8, 2022

Description

Amélioration de la qualité du code en renommant name en projectName et description en projectDescription dans le Starter Kit.

Type de changement

  • Refactoring

Checklist

  • Ma Pull Request pointe vers la bonne branche
  • Mon code suit le style de code du projet
  • J'ai effectué une review de mon propre code
  • J'ai commenté mon code, en particulier dans les parties difficiles à comprendre
  • J'ai apporté les modifications correspondantes à la documentation
  • Mes modifications ne génèrent aucun nouveau warning
  • J'ai ajouté des tests qui prouvent que mon correctif est efficace ou que ma fonctionnalité fonctionne
  • Les tests unitaires passent localement avec mes modifications
  • J'ai mis à jour le fichier Changelog

@codecov
Copy link

codecov bot commented Apr 8, 2022

Codecov Report

Merging #1908 (03716b0) into dev (fcfa312) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               dev     #1908   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          178       178           
  Lines         1189      1189           
  Branches       157       157           
=========================================
  Hits          1189      1189           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fcfa312...03716b0. Read the comment docs.

@deraw deraw merged commit 7a25f77 into dev Apr 8, 2022
@deraw deraw deleted the vue-dash/refactor/improve-code-quality branch April 8, 2022 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant