Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ vue-dot: Add CookiesPage template #1924

Merged
merged 2 commits into from
Apr 19, 2022
Merged

✨ vue-dot: Add CookiesPage template #1924

merged 2 commits into from
Apr 19, 2022

Conversation

deraw
Copy link
Member

@deraw deraw commented Apr 14, 2022

Description

Ajout du nouveau template CookiesPage.

Todo:

  • Validation des modifications graphiques
  • Ajout d'une confirmation lors de la sauvegarde
  • Ajout des tests
  • Ajout de la documentation

Playground

<template>
	<CookiesPage :items="cookiesList" />
</template>

<script lang="ts">
	import Vue from 'vue';
	import Component from 'vue-class-component';

	import { TypeEnum } from '../src/templates/CookiesPage/CookiesInformation/TypeEnum';
	import { CookiesPageItems } from '../src/templates/CookiesPage/types';

	@Component
	export default class Playground extends Vue {
		cookies = [
			{
				name: 'lorem-ipsum',
				description: 'Lorem ipsum dolor sit amet, consectetur adipiscing elit.',
				conservation: '13 mois'
			},
			{
				name: 'lorem-ipsum',
				description: 'Lorem ipsum dolor sit amet, consectetur adipiscing elit.',
				conservation: '13 mois'
			}
		];

		cookiesList: CookiesPageItems = {
			[TypeEnum.ESSENTIALS]: this.cookies,
			[TypeEnum.FUNCTIONAL]: this.cookies
		};
	}
</script>

Type de changement

  • Nouvelle fonctionnalité
  • Ce changement nécessite une mise à jour de la documentation

Checklist

  • Ma Pull Request pointe vers la bonne branche
  • Mon code suit le style de code du projet
  • J'ai effectué une review de mon propre code
  • J'ai commenté mon code, en particulier dans les parties difficiles à comprendre
  • J'ai apporté les modifications correspondantes à la documentation
  • Mes modifications ne génèrent aucun nouveau warning
  • J'ai ajouté des tests qui prouvent que mon correctif est efficace ou que ma fonctionnalité fonctionne
  • Les tests unitaires passent localement avec mes modifications
  • J'ai mis à jour le fichier Changelog

@deraw deraw force-pushed the vue-dot/feat/cookie-page branch from 9017eb9 to ebd7e28 Compare April 14, 2022 15:58
@deraw deraw force-pushed the vue-dot/feat/cookie-page branch from ebd7e28 to d4baa43 Compare April 14, 2022 16:01
@deraw deraw linked an issue Apr 14, 2022 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Apr 14, 2022

Codecov Report

Merging #1924 (d3ad59e) into dev (b92dc04) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##               dev     #1924   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          181       189    +8     
  Lines         1205      1223   +18     
  Branches       157       157           
=========================================
+ Hits          1205      1223   +18     
Impacted Files Coverage Δ
.../CookiesPage/CookiesInformation/RadioValuesEnum.ts 100.00% <100.00%> (ø)
...mplates/CookiesPage/CookiesInformation/TypeEnum.ts 100.00% <100.00%> (ø)
.../templates/CookiesPage/CookiesInformation/index.ts 100.00% <100.00%> (ø)
...emplates/CookiesPage/CookiesInformation/locales.ts 100.00% <100.00%> (ø)
.../src/templates/CookiesPage/CookiesTable/headers.ts 100.00% <100.00%> (ø)
...ot/src/templates/CookiesPage/CookiesTable/index.ts 100.00% <100.00%> (ø)
...ackages/vue-dot/src/templates/CookiesPage/index.ts 100.00% <100.00%> (ø)
...kages/vue-dot/src/templates/CookiesPage/locales.ts 100.00% <100.00%> (ø)
packages/vue-dot/src/templates/index.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b92dc04...d3ad59e. Read the comment docs.

@deraw deraw changed the title ✨ vue-dot: Add CookiePage template ✨ vue-dot: Add CookiesPage template Apr 19, 2022
@deraw deraw force-pushed the vue-dot/feat/cookie-page branch from be5d2f9 to b4870f7 Compare April 19, 2022 12:35
@deraw deraw force-pushed the vue-dot/feat/cookie-page branch from b4870f7 to d3ad59e Compare April 19, 2022 12:37
@deraw deraw marked this pull request as ready for review April 19, 2022 12:41
@deraw deraw merged commit ae650be into dev Apr 19, 2022
@deraw deraw deleted the vue-dot/feat/cookie-page branch April 19, 2022 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Intégration du composant pour le consentement des cookies
1 participant