Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DatePicker: fix properties #3855

Merged
merged 4 commits into from
Dec 3, 2024
Merged

DatePicker: fix properties #3855

merged 4 commits into from
Dec 3, 2024

Conversation

DavidFyon
Copy link
Contributor

@DavidFyon DavidFyon commented Dec 2, 2024

Description

Add missing properties

Playground

<template>
	<PeriodField
		v-model="periodValue"
		:outlined="outlined"
		:disabled="disabled"
		:readonly="readonly"
		:text-field-activator="textFieldActivator"
	/>
</template>

<script lang="ts">
	import Vue from 'vue';
	import Component from 'vue-class-component';
	import PeriodField from '@cnamts/vue-dot/src/patterns/PeriodField';

	@Component({
		components: { PeriodField }
	})
	export default class Playground extends Vue {
		periodValue = {
			from: null,
			to: null
		};

		outlined = false;
		disabled = false;
		readonly = true;
		textFieldActivator = false;
	}
</script>

Type de changement

  • Nouvelle fonctionnalité
  • Correction de bug
  • Changement cassant
  • Refactoring
  • Maintenance
  • Documentation
  • Ce changement nécessite une mise à jour de la documentation

Checklist

  • Ma Pull Request pointe vers la bonne branche
  • Mon code suit le style de code du projet
  • J'ai effectué une review de mon propre code
  • J'ai commenté mon code, en particulier dans les parties difficiles à comprendre
  • J'ai apporté les modifications correspondantes à la documentation
  • Mes modifications ne génèrent aucun nouveau warning
  • J'ai ajouté des tests qui prouvent que mon correctif est efficace ou que ma fonctionnalité fonctionne
  • Les tests unitaires passent localement avec mes modifications
  • J'ai mis à jour le fichier Changelog

Copy link

codecov bot commented Dec 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (d448376) to head (f49b368).
Report is 1 commits behind head on v2.

Additional details and impacted files
@@            Coverage Diff            @@
##                v2     #3855   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          249       249           
  Lines         1524      1524           
  Branches       195       195           
=========================================
  Hits          1524      1524           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DavidFyon DavidFyon merged commit 3bb02c9 into v2 Dec 3, 2024
9 checks passed
@DavidFyon DavidFyon deleted the fix/date-picker-properties branch December 3, 2024 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Attributs text-field-activator et readonly sur PeriodField ne fonctionne pas
2 participants