Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ vue-dot: Use widthable mixin in DataList #981

Merged
merged 1 commit into from
Mar 25, 2021

Conversation

deraw
Copy link
Member

@deraw deraw commented Mar 25, 2021

Description

Utilisation de la mixin widthable sur le composant DataList

Comme nous allons ajouter le composant DataListGroup, l'item ne porte plus la largeur, c'est directement la DataList que l'on dimensionne

Le guide de migration sera ajouté avec le composant DataListGroup

Type de changement

  • Refactoring
  • Ce changement nécessite une mise à jour de la documentation

Checklist

  • Ma Pull Request pointe vers la bonne branche
  • Mon code suit le style de code du projet
  • J'ai effectué une review de mon propre code
  • J'ai commenté mon code, en particulier dans les parties difficiles à comprendre
  • J'ai apporté les modifications correspondantes à la documentation
  • Mes modifications ne génèrent aucun nouveau warning
  • J'ai ajouté des tests qui prouvent que mon correctif est efficace ou que ma fonctionnalité fonctionne
  • Les tests unitaires passent localement avec mes modifications
  • J'ai mis à jour le fichier Changelog

@deraw deraw added this to the v2.0.0-beta.8 milestone Mar 25, 2021
@deraw deraw force-pushed the vue-dot/refactor/data-list branch from 3709892 to 57c45b4 Compare March 25, 2021 14:26
@codecov
Copy link

codecov bot commented Mar 25, 2021

Codecov Report

Merging #981 (57c45b4) into dev (5e9ec77) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##               dev      #981   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          126       126           
  Lines         1008      1008           
  Branches       144       144           
=========================================
  Hits          1008      1008           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e9ec77...57c45b4. Read the comment docs.

@deraw deraw merged commit 38c0853 into dev Mar 25, 2021
@deraw deraw deleted the vue-dot/refactor/data-list branch March 25, 2021 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant