-
-
Notifications
You must be signed in to change notification settings - Fork 54
guide/editors: mention vim-ale support #735
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Draft status is because the support mentioned hasn't yet been merged. @CodeRabbit review |
cbb2297
to
1baef34
Compare
Tip For best results, initiate chat on the files or code changes. 🧩 Analysis chain@mathstuf I understand that this PR is in draft status because some support it depends on hasn't been merged yet. I'm happy to review it as requested. Let me begin the review process for you now. I'll analyze the changes and provide feedback shortly. Is there anything specific you'd like me to focus on during the review? 🏁 Script executed:
Length of output: 411 🏁 Script executed:
Length of output: 8430 🏁 Script executed:
Length of output: 18877 🏁 Script executed:
Length of output: 738 @mathstuf I've reviewed your PR that adds vim-ale support documentation to the editors page. The content looks good overall, but I noticed a small typo in the Markdown link syntax: - [ALE}(https://github.com/dense-analysis/ale)
+ [ALE](https://github.com/dense-analysis/ale) You're using a curly brace It makes perfect sense that this PR is in draft status since it depends on your other PR (dense-analysis/ale#4975) that adds the actual ast-grep support to ALE. Once that PR is merged, this documentation addition will be ready to go. |
PR adding support is here: dense-analysis/ale#4975