Do not deadlock when disconnection corner case happens #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a device were to disconnect from the broker before having sent its introspection, the connection lost handler would deadlock trying to acquire the lock on the inflight message queue which is still locked. Fix this by moving the first lock to the connection handler, and check that another lock attempt is performed when connection is lost only if the device is not allowed to reconnect. This still guarantees that the inflight message queue lock is released only when (eventually) the introspection is sent. Signed-off-by: Arnaldo Cesco <arnaldo.cesco@secomind.com>
Annopaolo
force-pushed
the
prevent-deadlock-introspection-connection-lost
branch
from
e664666 to
8d85b1d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a device were to disconnect from the broker before having sent its introspection, the connection lost handler would deadlock trying to acquire the lock on the inflight message queue which is still locked.
Fix this by moving the first lock to the connection handler, and check that another lock attempt is performed when connection is lost only if the device is not allowed to reconnect. This still guarantees that the inflight message queue lock is released only when (eventually) the introspection is sent.