Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Realm Management error feedback when creating triggers with invalid URLs #748

Closed
Pavinati opened this issue Jan 10, 2023 · 1 comment
Closed
Labels
app:realm_management_api This issue or pull request is about astarte_realm_management_api application good first issue Good for newcomers user experience This issue is about user experience
Milestone

Comments

@Pavinati
Copy link
Collaborator

When installing a trigger with an invalid URL, Realm Management should return an error message specifying why the entity is not valid. Same as other fields in the Trigger.
eg:

{"errors":{"name":["can't be blank"]}}

Action:
installing a trigger with an invalid http_url

Expected result:

{"errors":{"http_url":["is not a valid URL"]}}

Actual result:

{"errors":{}}
@Pavinati Pavinati added good first issue Good for newcomers user experience This issue is about user experience app:realm_management_api This issue or pull request is about astarte_realm_management_api application labels Jan 10, 2023
@rbino rbino added this to the v1.1 milestone Jan 17, 2023
@Annopaolo
Copy link
Collaborator

Closed by #750.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:realm_management_api This issue or pull request is about astarte_realm_management_api application good first issue Good for newcomers user experience This issue is about user experience
Projects
Status: Done
Development

No branches or pull requests

3 participants