RM API: provide useful feedback when trigger action is malformed #750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Annopaolo
added
user experience
Annopaolo
force-pushed
the
terse-trigger-action-errors
branch
from
7505f2f
to
4a8e185
Compare
Codecov Report
@@ Coverage Diff @@
## release-1.1 #750 +/- ##
================================================
- Coverage 68.43% 46.00% -22.44%
================================================
Files 258 17 -241
Lines 5911 300 -5611
================================================
- Hits 4045 138 -3907
+ Misses 1866 162 -1704 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Annopaolo
force-pushed
the
terse-trigger-action-errors
branch
from
4a8e185
to
5e56bfd
Compare
rbino
requested changes
Jan 31, 2023
Comment on lines
46
to
56
| def encode( | ||
| %Action{ | ||
| http_url: http_url, | ||
| http_method: http_method, | ||
| http_static_headers: http_static_headers, | ||
| template: template, | ||
| template_type: template_type | ||
| }, | ||
| opts | ||
| ) | ||
| when not is_nil(http_url) do |
There was a problem hiding this comment.
Extract only what is needed (i.e. http_url) in the function head, and extract the rest in the body
Comment on lines
68
to
67
| %Action{ | ||
| amqp_exchange: amqp_exchange, | ||
| amqp_routing_key: amqp_routing_key, | ||
| amqp_static_headers: amqp_headers, | ||
| amqp_message_expiration_ms: amqp_message_expiration_ms, | ||
| amqp_message_persistent: amqp_message_persistent, | ||
| amqp_message_priority: amqp_message_priority | ||
| }, | ||
| opts | ||
| ) | ||
| when not is_nil(amqp_exchange) do |
There was a problem hiding this comment.
Extract only what is needed (i.e. amqp_exchange) in the function head, and extract the rest in the body
…ormed Display detailed feedback upon failed installation of a trigger with malformed action field. Under the hood, the Trigger changeset now embeds a Action changeset that wraps a valid AMQP/HTTP action. Validation is still performed by the two related modules. The Action modules handles JSON encoding/decoding, too. Signed-off-by: Arnaldo Cesco <arnaldo.cesco@secomind.com>
Annopaolo
force-pushed
the
terse-trigger-action-errors
branch
from
5e56bfd
to
83e6ac7
Compare
rbino
approved these changes
Jan 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Display detailed feedback upon failed installation of a trigger with malformed action field.
Under the hood, the Trigger changeset now embeds an
Astarte.RealmManagement.API.Triggers.Actionchangeset that wraps a valid AMQP/HTTP action. Data validation is still performed by the two related modules.The Action modules handles JSON encoding/decoding, too.
Fixes #748.