Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

data_updater: serialize MessageTracker and DataUpdater.Server starts #377

Merged
merged 1 commit into from
May 14, 2020

Conversation

rbino
Copy link
Collaborator

@rbino rbino commented May 14, 2020

Avoid stalling a Data Updater when it is started through an RPC call instead of
being started by AMQPDataConsumer.

Fix #375

Signed-off-by: Riccardo Binetti riccardo.binetti@ispirata.com

Avoid stalling a Data Updater when it is started through an RPC call instead of
being started by AMQPDataConsumer.

Fix astarte-platform#375

Signed-off-by: Riccardo Binetti <riccardo.binetti@ispirata.com>
@rbino rbino added bug Something isn't working app:data_updater_plant This issue or pull request is about astarte_data_updater_plant application labels May 14, 2020
@rbino rbino requested a review from bettio May 14, 2020 13:49
@codecov
Copy link

codecov bot commented May 14, 2020

Codecov Report

Merging #377 into release-0.11 will decrease coverage by 0.55%.
The diff coverage is 100.00%.

Impacted file tree graph

@@               Coverage Diff                @@
##           release-0.11     #377      +/-   ##
================================================
- Coverage         68.05%   67.50%   -0.56%     
================================================
  Files               238      205      -33     
  Lines              4931     4739     -192     
================================================
- Hits               3356     3199     -157     
+ Misses             1575     1540      -35     
Impacted Files Coverage Δ
...astarte_data_updater_plant/consumers_supervisor.ex 100.00% <ø> (ø)
...b/astarte_data_updater_plant/amqp_data_consumer.ex 28.75% <100.00%> (+13.82%) ⬆️
...ata_updater_plant/amqp_data_consumer/supervisor.ex 100.00% <100.00%> (ø)
...ter_plant/lib/astarte_data_updater_plant/config.ex 90.00% <100.00%> (+1.11%) ⬆️
...ant/lib/astarte_data_updater_plant/data_updater.ex 91.83% <100.00%> (+0.72%) ⬆️
...e_pairing_api/agent/device_registration_request.ex
...e_pairing_api_web/views/credentials_status_view.ex
...astarte_pairing_api/lib/astarte_pairing_api_web.ex
...e_pairing_api/lib/astarte_pairing_api/auth/auth.ex
...i/lib/astarte_pairing_api_web/views/health_view.ex
... and 28 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 72e6292...216a4ba. Read the comment docs.

@bettio bettio merged commit 6de679d into astarte-platform:release-0.11 May 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:data_updater_plant This issue or pull request is about astarte_data_updater_plant application bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants