Add "Never Connected" and "Disconnected" fields #843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add "Never Connected Devices" and "Disconnected Devices" stats fields. Closes astarte-platform#157 Signed-off-by: Ismet Softic <ismet.softic@secomind.com>
Codecov Report
@@ Coverage Diff @@
## master #843 +/- ##
==========================================
- Coverage 67.42% 61.55% -5.88%
==========================================
Files 264 184 -80
Lines 6429 3967 -2462
==========================================
- Hits 4335 2442 -1893
+ Misses 2094 1525 -569
|
Annopaolo
requested changes
Dec 11, 2023
There was a problem hiding this comment.
Good starting point, some more work needs to be done:
- Document these changes: edit the
apps/astarte_appengine_api/priv/static/astarte_appengine_api.yamlto include the new fields - Add tests for newly added fields
- Add a line to CHANGELOG.md briefly describing what was added, keeping in mind that it is used mostly to communicate changes to users.
| ALLOW FILTERING | ||
| """ | ||
|
|
||
| with {:ok, prepared} <- prepare_with_realm(conn, realm, query), |
There was a problem hiding this comment.
We will move away from doing string interpolation for realm name. Add a TODO here to remind us of changing the query.
Comment on lines
+102
to
+103
| {:ok, %Xandra.Page{} = page} <- Xandra.execute(conn, prepared, %{}) do | ||
| devices = Enum.to_list(page) |
There was a problem hiding this comment.
What will happen here if the number of never connected devices is bigger than the page size?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add "Never Connected Devices" and "Disconnected Devices" stats fields.
Closes #157