Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dialyxir: do not fail randomly #873

Merged
merged 1 commit into from
Nov 15, 2023

Conversation

Annopaolo
Copy link
Collaborator

mix dialyzer randomly fails when using Dialyxir < 1.4 with dependency missing (see jeremyjh/dialyxir#511). This happens most notably in CI.
Update dialyxir to latest (1.4.2) version to fix it.

`mix dialyzer` randomly fails when using Dialyxir < 1.4
with `dependency missing` (see jeremyjh/dialyxir#511).
This happens most notably in CI.
Update dialyxir to latest (1.4.2) version to fix it.

Signed-off-by: Arnaldo Cesco <arnaldo.cesco@secomind.com>
@Annopaolo Annopaolo added testing This issue or pull request is about testing and coverage dependencies Pull requests that update a dependency file labels Nov 15, 2023
Copy link

codecov bot commented Nov 15, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b19c5ac) 64.14% compared to head (d3ea3d6) 68.75%.
Report is 7 commits behind head on release-1.0.

❗ Current head d3ea3d6 differs from pull request most recent head ceabb8c. Consider uploading reports for the commit ceabb8c to get more accurate results

Additional details and impacted files
@@               Coverage Diff               @@
##           release-1.0     #873      +/-   ##
===============================================
+ Coverage        64.14%   68.75%   +4.61%     
===============================================
  Files              167      247      +80     
  Lines             3754     5547    +1793     
===============================================
+ Hits              2408     3814    +1406     
- Misses            1346     1733     +387     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bettio bettio merged commit 5030280 into astarte-platform:release-1.0 Nov 15, 2023
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file testing This issue or pull request is about testing and coverage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants