Gghio/692/trigger name events #923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Annopaolo
requested changes
Apr 12, 2024
apps/astarte_trigger_engine/lib/astarte_trigger_engine/events_consumer.ex
Outdated
Show resolved
Hide resolved
apps/astarte_trigger_engine/lib/astarte_trigger_engine/events_consumer.ex
Outdated
Show resolved
Hide resolved
apps/astarte_appengine_api/lib/astarte_appengine_api/rpc/data_updater_plant.ex
Outdated
Show resolved
Hide resolved
shinnokdisengir
force-pushed
the
gghio/692/trigger-name-events
branch
5 times, most recently
from
8e60a64
to
4f06994
Compare
Annopaolo
requested changes
Apr 17, 2024
Changed - send_simple_event - retrieve_trigger_configuration to integrate trigger_name inside payload FIX astarte-platform#692 Signed-off-by: Gabriele Ghio <gabriele.ghio@secomind.com>
Added trigger_name config information Signed-off-by: Gabriele Ghio <gabriele.ghio@secomind.com>
Signed-off-by: Gabriele Ghio <gabriele.ghio@secomind.com>
shinnokdisengir
force-pushed
the
gghio/692/trigger-name-events
branch
from
4f06994
to
296e96a
Compare
Annopaolo
approved these changes
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
astarte_trigger_engine: add
trigger_nameto http eventRelative to #692
Currently, when a Trigger delivers an Event, the Event does not contain any information about the Trigger that generated it. This means that to distinguish between two triggers on the same interface, users have to use some out of band mechanism (e.g. using a different URL or adding a fixed query parameter).
trigger_nameboth in mustache template and event payloadNo tests in this PR (there aren't tests for event data validation)