Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add appengine device commands #234

Merged
merged 1 commit into from
Dec 6, 2023

Conversation

eddbbt
Copy link
Contributor

@eddbbt eddbbt commented Nov 27, 2023

Deprecate send-data command, splitted in publish-datastream, set-property and unset-property

@eddbbt eddbbt force-pushed the appengine_rename branch 3 times, most recently from 5dcec11 to db26a11 Compare November 27, 2023 16:45
@eddbbt eddbbt marked this pull request as ready for review November 27, 2023 16:49
Copy link
Collaborator

@Annopaolo Annopaolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nitpicking, but the overall PR is good

cmd/appengine/device.go Outdated Show resolved Hide resolved
cmd/appengine/device.go Outdated Show resolved Hide resolved
cmd/appengine/device.go Outdated Show resolved Hide resolved
cmd/appengine/device.go Outdated Show resolved Hide resolved
cmd/appengine/device.go Outdated Show resolved Hide resolved
cmd/appengine/device.go Outdated Show resolved Hide resolved
cmd/appengine/device.go Outdated Show resolved Hide resolved
cmd/appengine/device.go Outdated Show resolved Hide resolved
@eddbbt eddbbt mentioned this pull request Nov 29, 2023
@eddbbt eddbbt requested a review from Annopaolo November 29, 2023 10:01
cmd/appengine/device.go Show resolved Hide resolved
cmd/appengine/device.go Outdated Show resolved Hide resolved
Deprecate send-data command, splitted in publish-datastream, set-property and unset-property

Signed-off-by: Eddy Babetto <eddy.babetto@secomind.com>
@Annopaolo Annopaolo merged commit 3ce93fc into astarte-platform:master Dec 6, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants