Add possibility to export progress bar for RevealJS #331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
astefanutti
reviewed
May 28, 2024
plugins/reveal.js
Outdated
| // or ...?progress=<true|false>, so we work around that by parsing the page query string | ||
| { | ||
| fragments: (URI(this.page.url()).query(true)['fragments'] || 'false').toLowerCase() === 'true', | ||
| progress: (URI(this.page.url()).query(true)['progress'] || 'false').toLowerCase() === 'true' |
There was a problem hiding this comment.
I'm not sure we want to replicate the work-around in place for fragments. If it works, it may be simpler / better to define a proper option for the revealjs plugin. Here is an example from the generic plugin:
Line 8 in 6735cec
There was a problem hiding this comment.
Sounds good to me - I implemented a version that works for me with decktape reveal --fragments=true --progress=true http://localhost:9999/ test.pdf. Let me know what you think about it.
I force-pushed it to my last commit. I don't know whether this is the right way to "update" pull requests; so if there is a preferred way, let me know :)
astefanutti
approved these changes
May 28, 2024
astefanutti
changed the title
astefanutti
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the possibility to add the progress bar to revealjs pdf exports as wanted in #330.