Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is this redundant as of 1.19.4-pre1? #32

Open
HyperSoop opened this issue Feb 24, 2023 · 7 comments
Open

Is this redundant as of 1.19.4-pre1? #32

HyperSoop opened this issue Feb 24, 2023 · 7 comments

Comments

@HyperSoop
Copy link

They seem to have implemented simular funcitonality into the base game in 1.19.4-pre1. What is the future of this mod?

@astei
Copy link
Owner

astei commented Feb 24, 2023

TL;DR: "redundant" isn't the correct word, "unnecessary" is better.

Mojang has indeed optimized DFU initialization to the point where it does not take an egregious amount of time. I checked on my M1 Max MBP with a small mixin, and it's looking to take 50 milliseconds now, largely due to optimizations in DFU and baking only the most essential level rules at startup, which combined also allowed Mojang to devote only a single low-priority background thread to DFU initialization.

With bake times as low as this, I'd call DFU rule baking a negligible factor in Minecraft startup times at this point, and I'd feel comfortable announcing the deprecation of LazyDFU once 1.19.4 is out.

That said, the mod remains useful for earlier versions of Minecraft, so it'll continue to remain available for those purposes, but I simply won't update it any more.

@EvanHsieh0415
Copy link

TL;DR: "redundant" isn't the correct word, "unnecessary" is better.

Mojang has indeed optimized DFU initialization to the point where it does not take an egregious amount of time. I checked on my M1 Max MBP with a small mixin, and it's looking to take 50 milliseconds now, largely due to optimizations in DFU and baking only the most essential level rules at startup, which combined also allowed Mojang to devote only a single low-priority background thread to DFU initialization.

With bake times as low as this, I'd call DFU rule baking a negligible factor in Minecraft startup times at this point, and I'd feel comfortable announcing the deprecation of LazyDFU once 1.19.4 is out.

That said, the mod remains useful for earlier versions of Minecraft, so it'll continue to remain available for those purposes, but I simply won't update it any more.

Are you saying that you won't update to the latest version, but you will still update if there are updates needed for older versions?

@Boobies
Copy link

Boobies commented Mar 21, 2023

I mean it should work as-is for now. I don't see any reason why you wouldn't label it as 1.19.4-compatible and same for any future versions until it eventually breaks.

@ghost
Copy link

ghost commented Jul 4, 2023

TL;DR: "redundant" isn't the correct word, "unnecessary" is better.

Mojang has indeed optimized DFU initialization to the point where it does not take an egregious amount of time. I checked on my M1 Max MBP with a small mixin, and it's looking to take 50 milliseconds now, largely due to optimizations in DFU and baking only the most essential level rules at startup, which combined also allowed Mojang to devote only a single low-priority background thread to DFU initialization.

With bake times as low as this, I'd call DFU rule baking a negligible factor in Minecraft startup times at this point, and I'd feel comfortable announcing the deprecation of LazyDFU once 1.19.4 is out.

That said, the mod remains useful for earlier versions of Minecraft, so it'll continue to remain available for those purposes, but I simply won't update it any more.

So, if this Mod is no longer needed starting from Minecraft 1.19.4, why do you update this mod for Minecraft 1.19.4+?And Minecraft 1.20+.

@astei
Copy link
Owner

astei commented Jul 4, 2023 via email

@ColonelGerdauf
Copy link

ColonelGerdauf commented Jul 5, 2023

I think a part of the problem is that the notice is after a bit of technical text, which many people will skip through for reasons ranging from perceived familiarity of the mod and the unwillingness of many to read through seemingly technical information.

I believe it will help to put a TLDR notice at the top of the description. It will help a bit when downloading from the sites, and especially when one wants to download the mod through launchers such as Prism, where the desrciption page will be upfront.

@ghost
Copy link

ghost commented Jul 6, 2023

因为有太多人无法阅读我发布的通知并要求“更新”——事实上,不需要更新,我只是标记了该 mod 与 1.20(确实如此)兼容只是为了让他们安静。
...
On Tue, Jul 4, 2023, at 12:37 AM, user123456 wrote: > TL;DR: "redundant" isn't the correct word, "unnecessary" is better. > > Mojang has indeed optimized DFU initialization to the point where it does not take an egregious amount of time. I checked on my M1 Max MBP with a small mixin https://gist.github.com/astei/5f7fbf6efcf0fa55c14f7d36d48e8ccf, and it's looking to take 50 milliseconds now, largely due to optimizations in DFU and baking only the most essential level rules at startup, which combined also allowed Mojang to devote only a single low-priority background thread to DFU initialization. > > With bake times as low as this, I'd call DFU rule baking a negligible factor in Minecraft startup times at this point, and I'd feel comfortable announcing the deprecation of LazyDFU once 1.19.4 is out. > > That said, the mod remains useful for earlier versions of Minecraft, so it'll continue to remain available for those purposes, but I simply won't update it any more. > So, if this Mod is no longer needed starting from Minecraft 1.19.4, why do you update this mod for Minecraft 1.19.4+ version? — Reply to this email directly, view it on GitHub <#32 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AD5MX5EKJTIRRVRIUSIKKFDXOOMXLANCNFSM6AAAAAAVG27RMM. You are receiving this because you commented.Message ID: @.***>

Oh!Thank you very much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants