The ability to keeping the console on Windows OS #47
Conversation
I have no idea what is it for (figured out using trial and error method), but I can't validate and start apps without `CFBundlePackageType` element.
| @@ -138,6 +141,7 @@ type Bundler struct { | |||
| pathWorkingDirectory string | |||
| pathManifest string | |||
| resourcesAdapters []ConfigurationResourcesAdapter | |||
| KeepWindowsConsole bool | |||
There was a problem hiding this comment.
Could you make the first letter a lower case letter (keepWindowsConsole) so that it's not exported?
| @@ -360,7 +365,7 @@ func (b *Bundler) bundle(e ConfigurationEnvironment) (err error) { | |||
| `"main.BuiltAt=` + time.Now().String() + `"`, | |||
| }, | |||
| } | |||
| if e.OS == "windows" { | |||
| if e.OS == "windows" && b.KeepWindowsConsole != true { | |||
There was a problem hiding this comment.
Is there a reason why you don't use !b.KeepWindowsConsole instead of b.KeepWindowsConsole != true since b.KeepWindowsConsole is a bool?
There was a problem hiding this comment.
Hi! Not have any reasons, just learning the language and still getting confused :)
There was a problem hiding this comment.
OK could you replace it with !b.KeepWindowsConsole then ?
|
I stumbled upon this when looking for a solution to keep the console open on windows, let me know if I can help with testing or something :) |
|
Thanks for proposing your help @marccardinal. Right now I'm waiting for @NightMan-1 to make the few minor changes I requested, but once the PR is merged I'd welcome testing it in other conditions. Cheers |
I need console in my app, this option allow keep it, may be this will be interesting other people's :)