Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update opam #5

Merged
merged 2 commits into from
Jan 29, 2017
Merged

Update opam #5

merged 2 commits into from
Jan 29, 2017

Conversation

constfun
Copy link
Contributor

@constfun constfun commented Jan 27, 2017

Since the changes from @jendas1 were merged we should probably allow opam to install ocamlfuse on mac.

As published, opam install ocamlfuse fails with platform check.
With this change opam pin installs the package fine.

Since the changes from @jendas1 were [merged](astrada#3) we should probably allow opam to install on mac.

As published, `opam install ocamlfuse` fails with platform check.
With this change `opam pin` installs the package fine.
@astrada
Copy link
Owner

astrada commented Jan 28, 2017

Yes, the problem is that opam needs also the correct depexts entry for osx. If you know the name of the FUSE package in homebrew, I could add a line like: [["osx" "homebrew"] ["fuse-package-name"]]. This way the CI system used by the opam repository should be able to compile it and the package could be accepted.

@constfun
Copy link
Contributor Author

Good idea and better now than never, so here it goes:

I originally installed the binary distribution from https://osxfuse.github.io and that works.

The FUSE for macOS includes a "Preference Panel" that shows up in system preferences. This (ie. a package bundled with a GUI) generally means that the package would be in the cask tap for homebrew.

I've added the fully qualified name to the required cask to the opam file as you've suggested:

  • If the user has caskroom tapped, running opam depext ocamlfuse will install the required dependency and ocamlfuse can be compiled.
  • If the user doesn't have caskroom tapped (a likely scenario) opam is actually smart enough to tap the cask and only then install the dependency. Great!

Tested with a local pin first with -n to run opam depext without installing, and then a simple opam install ocamlfuse to make sure that it compiles.

Late 2015 iMac with macOS Sierra (10.12.2)
opam version 1.2.2
ocaml version 4.04.0

@astrada
Copy link
Owner

astrada commented Jan 29, 2017

Great, thanks! I'll give it a try!

@astrada astrada merged commit f6e35a0 into astrada:master Jan 29, 2017
@astrada
Copy link
Owner

astrada commented Jan 29, 2017

It worked! This is the PR to the official repository. Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants