Code review changes

astral-sh · Jun 26, 2024 · 02b5c55 · 02b5c55
1 parent 4907e45
commit 02b5c55
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 9 deletions.
diff --git a/crates/ruff/src/printer.rs b/crates/ruff/src/printer.rs
@@ -80,7 +80,7 @@ impl Serialize for SerializeMessageKindAsTitle {
 
 impl Display for SerializeMessageKindAsTitle {
     fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
-        write!(f, "{}", self.0.as_str())
+        f.write_str(self.0.as_str())
     }
 }
 

diff --git a/crates/ruff_linter/src/message/github.rs b/crates/ruff_linter/src/message/github.rs
@@ -49,15 +49,10 @@ impl Emitter for GithubEmitter {
             )?;
 
             if let Some(rule) = message.rule() {
-                writeln!(
-                    writer,
-                    " {code} {body}",
-                    code = rule.noqa_code(),
-                    body = message.body()
-                )?;
-            } else {
-                writeln!(writer, " {}", message.body())?;
+                write!(writer, " {}", rule.noqa_code())?;
             }
+
+            writeln!(writer, " {}", message.body())?;
         }
 
         Ok(())

diff --git a/crates/ruff_workspace/src/configuration.rs b/crates/ruff_workspace/src/configuration.rs
@@ -1550,6 +1550,7 @@ mod tests {
             Rule::AmbiguousClassName,
             Rule::AmbiguousFunctionName,
             Rule::IOError,
+            Rule::SyntaxError,
             Rule::TabIndentation,
             Rule::TrailingWhitespace,
             Rule::MissingNewlineAtEndOfFile,