Skip to content

Commit

Permalink
Change lambda dummy to NOT_YET_IMPLEMENTED_lambda (#5687)
Browse files Browse the repository at this point in the history
This only changes the dummy to be easier to identify.
  • Loading branch information
konstin authored Jul 11, 2023
1 parent df15ad9 commit 0c8ec80
Show file tree
Hide file tree
Showing 10 changed files with 56 additions and 51 deletions.
7 changes: 6 additions & 1 deletion crates/ruff_python_formatter/src/expression/expr_lambda.rs
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,12 @@ pub struct FormatExprLambda;

impl FormatNodeRule<ExprLambda> for FormatExprLambda {
fn fmt_fields(&self, _item: &ExprLambda, f: &mut PyFormatter) -> FormatResult<()> {
write!(f, [not_yet_implemented_custom_text("lambda x: True")])
write!(
f,
[not_yet_implemented_custom_text(
"lambda NOT_YET_IMPLEMENTED_lambda: True"
)]
)
}
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -61,16 +61,16 @@ lambda a, b=1, /, c=2, d=3, *, e=4, f=5: 1
-lambda a, /: a
+lambda x: True
+lambda NOT_YET_IMPLEMENTED_lambda: True
-lambda a, b, /, c, d, *, e, f: a
+lambda x: True
+lambda NOT_YET_IMPLEMENTED_lambda: True
-lambda a, b, /, c, d, *args, e, f, **kwargs: args
+lambda x: True
+lambda NOT_YET_IMPLEMENTED_lambda: True
-lambda a, b=1, /, c=2, d=3, *, e=4, f=5: 1
+lambda x: True
+lambda NOT_YET_IMPLEMENTED_lambda: True
```

## Ruff Output
Expand Down Expand Up @@ -113,13 +113,13 @@ def long_one_with_long_parameter_names(
pass
lambda x: True
lambda NOT_YET_IMPLEMENTED_lambda: True
lambda x: True
lambda NOT_YET_IMPLEMENTED_lambda: True
lambda x: True
lambda NOT_YET_IMPLEMENTED_lambda: True
lambda x: True
lambda NOT_YET_IMPLEMENTED_lambda: True
```

## Black Output
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -76,10 +76,10 @@ while x := f(x):
-(x := lambda: 1)
-(x := lambda: (y := 1))
-lambda line: (m := re.match(pattern, line)) and m.group(1)
+lambda x: True
+(x := lambda x: True)
+(x := lambda x: True)
+lambda x: True
+lambda NOT_YET_IMPLEMENTED_lambda: True
+(x := lambda NOT_YET_IMPLEMENTED_lambda: True)
+(x := lambda NOT_YET_IMPLEMENTED_lambda: True)
+lambda NOT_YET_IMPLEMENTED_lambda: True
x = (y := 0)
(z := (y := (x := 0)))
(info := (name, phone, *rest))
Expand Down Expand Up @@ -132,10 +132,10 @@ def foo(answer: (p := 42) = 5):
pass
lambda x: True
(x := lambda x: True)
(x := lambda x: True)
lambda x: True
lambda NOT_YET_IMPLEMENTED_lambda: True
(x := lambda NOT_YET_IMPLEMENTED_lambda: True)
(x := lambda NOT_YET_IMPLEMENTED_lambda: True)
lambda NOT_YET_IMPLEMENTED_lambda: True
x = (y := 0)
(z := (y := (x := 0)))
(info := (name, phone, *rest))
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,17 +23,17 @@ lambda x=lambda y={1: 3}: y['x':lambda y: {1: 2}]: x
pass
-pem_spam = lambda l, spam={"x": 3}: not spam.get(l.strip())
-lambda x=lambda y={1: 3}: y["x" : lambda y: {1: 2}]: x
+pem_spam = lambda x: True
+lambda x: True
+pem_spam = lambda NOT_YET_IMPLEMENTED_lambda: True
+lambda NOT_YET_IMPLEMENTED_lambda: True
```

## Ruff Output

```py
for ((x in {}) or {})["a"] in x:
pass
pem_spam = lambda x: True
lambda x: True
pem_spam = lambda NOT_YET_IMPLEMENTED_lambda: True
lambda NOT_YET_IMPLEMENTED_lambda: True
```

## Black Output
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -291,13 +291,13 @@ last_call()
- "port1": port1_resource,
- "port2": port2_resource,
-}[port_id]
+lambda x: True
+lambda x: True
+lambda x: True
+lambda x: True
+lambda x: True
+manylambdas = lambda x: True
+foo = lambda x: True
+lambda NOT_YET_IMPLEMENTED_lambda: True
+lambda NOT_YET_IMPLEMENTED_lambda: True
+lambda NOT_YET_IMPLEMENTED_lambda: True
+lambda NOT_YET_IMPLEMENTED_lambda: True
+lambda NOT_YET_IMPLEMENTED_lambda: True
+manylambdas = lambda NOT_YET_IMPLEMENTED_lambda: True
+foo = lambda NOT_YET_IMPLEMENTED_lambda: True
1 if True else 2
str or None if True else str or bytes or None
(str or None) if True else (str or bytes or None)
Expand Down Expand Up @@ -494,7 +494,7 @@ last_call()
+ if False
+ else {NOT_IMPLEMENTED_dict_key: NOT_IMPLEMENTED_dict_value for key, value in NOT_IMPLEMENTED_dict}
+)
+print(*lambda x: True)
+print(*lambda NOT_YET_IMPLEMENTED_lambda: True)
+NOT_YET_IMPLEMENTED_StmtAssert
+NOT_YET_IMPLEMENTED_StmtAssert
+NOT_YET_IMPLEMENTED_StmtAssert
Expand Down Expand Up @@ -581,13 +581,13 @@ not great
(~int) and (not ((v1 ^ (123 + v2)) | True))
+really ** -confusing ** ~operator**-precedence
flags & ~select.EPOLLIN and waiters.write_task is not None
lambda x: True
lambda x: True
lambda x: True
lambda x: True
lambda x: True
manylambdas = lambda x: True
foo = lambda x: True
lambda NOT_YET_IMPLEMENTED_lambda: True
lambda NOT_YET_IMPLEMENTED_lambda: True
lambda NOT_YET_IMPLEMENTED_lambda: True
lambda NOT_YET_IMPLEMENTED_lambda: True
lambda NOT_YET_IMPLEMENTED_lambda: True
manylambdas = lambda NOT_YET_IMPLEMENTED_lambda: True
foo = lambda NOT_YET_IMPLEMENTED_lambda: True
1 if True else 2
str or None if True else str or bytes or None
(str or None) if True else (str or bytes or None)
Expand Down Expand Up @@ -785,7 +785,7 @@ print(
if False
else {NOT_IMPLEMENTED_dict_key: NOT_IMPLEMENTED_dict_value for key, value in NOT_IMPLEMENTED_dict}
)
print(*lambda x: True)
print(*lambda NOT_YET_IMPLEMENTED_lambda: True)
NOT_YET_IMPLEMENTED_StmtAssert
NOT_YET_IMPLEMENTED_StmtAssert
NOT_YET_IMPLEMENTED_StmtAssert
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -271,7 +271,7 @@ d={'a':1,
def spaces(a=1, b=(), c=[], d={}, e=True, f=-1, g=1 if False else 2, h="", i=r""):
- offset = attr.ib(default=attr.Factory(lambda: _r.uniform(1, 2)))
- assert task._cancel_stack[: len(old_stack)] == old_stack
+ offset = attr.ib(default=attr.Factory(lambda x: True))
+ offset = attr.ib(default=attr.Factory(lambda NOT_YET_IMPLEMENTED_lambda: True))
+ NOT_YET_IMPLEMENTED_StmtAssert
Expand Down Expand Up @@ -457,7 +457,7 @@ def function_signature_stress_test(
# fmt: on
def spaces(a=1, b=(), c=[], d={}, e=True, f=-1, g=1 if False else 2, h="", i=r""):
offset = attr.ib(default=attr.Factory(lambda x: True))
offset = attr.ib(default=attr.Factory(lambda NOT_YET_IMPLEMENTED_lambda: True))
NOT_YET_IMPLEMENTED_StmtAssert
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ def __await__(): return (yield)
def spaces(a=1, b=(), c=[], d={}, e=True, f=-1, g=1 if False else 2, h="", i=r""):
- offset = attr.ib(default=attr.Factory(lambda: _r.uniform(10000, 200000)))
- assert task._cancel_stack[: len(old_stack)] == old_stack
+ offset = attr.ib(default=attr.Factory(lambda x: True))
+ offset = attr.ib(default=attr.Factory(lambda NOT_YET_IMPLEMENTED_lambda: True))
+ NOT_YET_IMPLEMENTED_StmtAssert


Expand Down Expand Up @@ -229,7 +229,7 @@ def function_signature_stress_test(


def spaces(a=1, b=(), c=[], d={}, e=True, f=-1, g=1 if False else 2, h="", i=r""):
offset = attr.ib(default=attr.Factory(lambda x: True))
offset = attr.ib(default=attr.Factory(lambda NOT_YET_IMPLEMENTED_lambda: True))
NOT_YET_IMPLEMENTED_StmtAssert


Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ return np.divide(
c = -(5**2)
d = 5 ** f["hi"]
-e = lazy(lambda **kwargs: 5)
+e = lazy(lambda x: True)
+e = lazy(lambda NOT_YET_IMPLEMENTED_lambda: True)
f = f() ** 5
g = a.b**c.d
h = 5 ** funcs.f()
Expand All @@ -98,7 +98,7 @@ return np.divide(
c = -(5.0**2.0)
d = 5.0 ** f["hi"]
-e = lazy(lambda **kwargs: 5)
+e = lazy(lambda x: True)
+e = lazy(lambda NOT_YET_IMPLEMENTED_lambda: True)
f = f() ** 5.0
g = a.b**c.d
h = 5.0 ** funcs.f()
Expand Down Expand Up @@ -147,7 +147,7 @@ a = 5**~4
b = 5 ** f()
c = -(5**2)
d = 5 ** f["hi"]
e = lazy(lambda x: True)
e = lazy(lambda NOT_YET_IMPLEMENTED_lambda: True)
f = f() ** 5
g = a.b**c.d
h = 5 ** funcs.f()
Expand All @@ -166,7 +166,7 @@ a = 5.0**~4.0
b = 5.0 ** f()
c = -(5.0**2.0)
d = 5.0 ** f["hi"]
e = lazy(lambda x: True)
e = lazy(lambda NOT_YET_IMPLEMENTED_lambda: True)
f = f() ** 5.0
g = a.b**c.d
h = 5.0 ** funcs.f()
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ for (((((k, v))))) in d.items():
for module in (core, _unicodefun):
if hasattr(module, "_verify_python3_env"):
- module._verify_python3_env = lambda: None
+ module._verify_python3_env = lambda x: True
+ module._verify_python3_env = lambda NOT_YET_IMPLEMENTED_lambda: True
# Brackets remain for long for loop lines
for (
Expand All @@ -63,7 +63,7 @@ for k, v in d.items():
# Don't touch tuple brackets after `in`
for module in (core, _unicodefun):
if hasattr(module, "_verify_python3_env"):
module._verify_python3_env = lambda x: True
module._verify_python3_env = lambda NOT_YET_IMPLEMENTED_lambda: True
# Brackets remain for long for loop lines
for (
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -59,8 +59,8 @@ ham[lower + offset : upper + offset]
-slice[lambda: None : lambda: None]
-slice[lambda x, y, *args, really=2, **kwargs: None :, None::]
+slice[ : -1 :]
+slice[lambda x: True : lambda x: True]
+slice[lambda x: True :, None::]
+slice[lambda NOT_YET_IMPLEMENTED_lambda: True : lambda NOT_YET_IMPLEMENTED_lambda: True]
+slice[lambda NOT_YET_IMPLEMENTED_lambda: True :, None::]
slice[1 or 2 : True and False]
slice[not so_simple : 1 < val <= 10]
-slice[(1 for i in range(42)) : x]
Expand Down Expand Up @@ -97,8 +97,8 @@ slice[c, c + 1, d::]
slice[ham[c::d] :: 1]
slice[ham[cheese**2 : -1] : 1 : 1, ham[1:2]]
slice[ : -1 :]
slice[lambda x: True : lambda x: True]
slice[lambda x: True :, None::]
slice[lambda NOT_YET_IMPLEMENTED_lambda: True : lambda NOT_YET_IMPLEMENTED_lambda: True]
slice[lambda NOT_YET_IMPLEMENTED_lambda: True :, None::]
slice[1 or 2 : True and False]
slice[not so_simple : 1 < val <= 10]
slice[
Expand Down

0 comments on commit 0c8ec80

Please sign in to comment.