Make cache-write failures non-fatal

astral-sh · Jul 12, 2024 · 4b8a7d2 · 4b8a7d2
1 parent 17e84d5
commit 4b8a7d2
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 6 deletions.
diff --git a/crates/ruff/src/cache.rs b/crates/ruff/src/cache.rs
@@ -180,12 +180,22 @@ impl Cache {
             .write_all(&serialized)
             .context("Failed to write serialized cache to temporary file.")?;
 
-        temp_file.persist(&self.path).with_context(|| {
-            format!(
-                "Failed to rename temporary cache file to {}",
-                self.path.display()
-            )
-        })?;
+        if let Err(err) = temp_file.persist(&self.path) {
+            if err.error.kind() == io::ErrorKind::PermissionDenied {
+                warn_user!(
+                    "Failed to write cache file '{}': {}",
+                    self.path.display(),
+                    err.error
+                );
+            } else {
+                return Err(err).with_context(|| {
+                    format!(
+                        "Failed to rename temporary cache file to {}",
+                        self.path.display()
+                    )
+                });
+            }
+        }
 
         Ok(())
     }

diff --git a/crates/ruff/src/commands/format.rs b/crates/ruff/src/commands/format.rs
@@ -176,6 +176,7 @@ pub(crate) fn format(
         duration
     );
 
+    // Store the caches.
     caches.persist()?;
 
     // Report on any errors.