Treat subscript accesses as unsafe effects for autofix (#1966)

See: #1809.
astral-sh · Jan 18, 2023 · 5a7d8c2 · 5a7d8c2
1 parent 26d6414
commit 5a7d8c2
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 3 deletions.
diff --git a/resources/test/fixtures/flake8_simplify/SIM401.py b/resources/test/fixtures/flake8_simplify/SIM401.py
@@ -85,3 +85,9 @@
     var = a_dict[key]
 else:
     var = foo()
+
+# OK (complex default value)
+if key in a_dict:
+    var = a_dict[key]
+else:
+    var = a_dict["fallback"]
diff --git a/src/ast/helpers.rs b/src/ast/helpers.rs
@@ -145,12 +145,13 @@ pub fn contains_effect(checker: &Checker, expr: &Expr) -> bool {
         // Otherwise, avoid all complex expressions.
         matches!(
             expr.node,
-            ExprKind::Call { .. }
-                | ExprKind::Await { .. }
+            ExprKind::Await { .. }
+                | ExprKind::Call { .. }
+                | ExprKind::DictComp { .. }
                 | ExprKind::GeneratorExp { .. }
                 | ExprKind::ListComp { .. }
                 | ExprKind::SetComp { .. }
-                | ExprKind::DictComp { .. }
+                | ExprKind::Subscript { .. }
                 | ExprKind::Yield { .. }
                 | ExprKind::YieldFrom { .. }
         )