-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Truncate to one empty line in stub files (#7558)
## Summary This PR modifies a variety of sites in which we insert up to two empty lines to instead truncate to at most one empty line in stub files. We already enforce this in _some_ places, but not all. ## Test Plan `cargo test` No changes in similarity (as expected, since this only impacts unformatted `.pyi` files). Before: | project | similarity index | total files | changed files | |--------------|------------------:|------------------:|------------------:| | cpython | 0.76083 | 1789 | 1631 | | django | 0.99983 | 2760 | 36 | | transformers | 0.99963 | 2587 | 323 | | twine | 1.00000 | 33 | 0 | | typeshed | 0.99979 | 3496 | 22 | | warehouse | 0.99967 | 648 | 15 | | zulip | 0.99972 | 1437 | 21 | After: | project | similarity index | total files | changed files | |--------------|------------------:|------------------:|------------------:| | cpython | 0.76083 | 1789 | 1631 | | django | 0.99983 | 2760 | 36 | | transformers | 0.99963 | 2587 | 323 | | twine | 1.00000 | 33 | 0 | | typeshed | 0.99979 | 3496 | 22 | | warehouse | 0.99967 | 648 | 15 | | zulip | 0.99972 | 1437 | 21 |
- Loading branch information
1 parent
c3774e1
commit d7508af
Showing
4 changed files
with
506 additions
and
6 deletions.
There are no files selected for viewing
161 changes: 161 additions & 0 deletions
161
crates/ruff_python_formatter/resources/test/fixtures/ruff/newlines.pyi
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,161 @@ | ||
### | ||
# Blank lines around functions | ||
### | ||
|
||
x = 1 | ||
|
||
# comment | ||
|
||
def f(): | ||
pass | ||
|
||
|
||
if True: | ||
x = 1 | ||
|
||
# comment | ||
|
||
def f(): | ||
pass | ||
|
||
|
||
x = 1 | ||
|
||
|
||
|
||
# comment | ||
|
||
def f(): | ||
pass | ||
|
||
|
||
x = 1 | ||
|
||
|
||
|
||
# comment | ||
def f(): | ||
pass | ||
|
||
|
||
x = 1 | ||
|
||
# comment | ||
|
||
# comment | ||
def f(): | ||
pass | ||
|
||
x = 1 | ||
|
||
# comment | ||
# comment | ||
|
||
def f(): | ||
pass | ||
|
||
x = 1 | ||
|
||
# comment | ||
# comment | ||
def f(): | ||
pass | ||
|
||
|
||
x = 1 | ||
|
||
|
||
# comment | ||
|
||
|
||
|
||
# comment | ||
|
||
|
||
|
||
def f(): | ||
pass | ||
# comment | ||
|
||
|
||
def f(): | ||
pass | ||
|
||
# comment | ||
|
||
def f(): | ||
pass | ||
|
||
|
||
# comment | ||
|
||
### | ||
# Blank lines around imports. | ||
### | ||
|
||
def f(): | ||
import x | ||
# comment | ||
import y | ||
|
||
|
||
def f(): | ||
import x | ||
|
||
# comment | ||
import y | ||
|
||
|
||
def f(): | ||
import x | ||
# comment | ||
|
||
import y | ||
|
||
|
||
def f(): | ||
import x | ||
# comment | ||
|
||
|
||
import y | ||
|
||
|
||
def f(): | ||
import x | ||
|
||
|
||
# comment | ||
import y | ||
|
||
|
||
def f(): | ||
import x | ||
|
||
# comment | ||
|
||
import y | ||
|
||
|
||
def f(): | ||
import x # comment | ||
# comment | ||
|
||
import y | ||
|
||
|
||
def f(): pass # comment | ||
# comment | ||
|
||
x = 1 | ||
|
||
|
||
def f(): | ||
pass | ||
|
||
|
||
|
||
|
||
# comment | ||
|
||
x = 1 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.