Skip to content

Commit

Permalink
Remove leftover constant tuple reference (#8062)
Browse files Browse the repository at this point in the history
This PR removes the leftover reference to the tuple variant in
`Constant`.
  • Loading branch information
dhruvmanila authored Oct 19, 2023
1 parent a327b4d commit ec1be60
Show file tree
Hide file tree
Showing 4 changed files with 2 additions and 5 deletions.
1 change: 0 additions & 1 deletion crates/ruff_linter/src/rules/pylint/settings.rs
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ pub enum ConstantType {
Float,
Int,
Str,
Tuple,
}

impl TryFrom<&Constant> for ConstantType {
Expand Down
1 change: 0 additions & 1 deletion crates/ruff_python_ast/src/comparable.rs
Original file line number Diff line number Diff line change
Expand Up @@ -333,7 +333,6 @@ pub enum ComparableConstant<'a> {
Str { value: &'a str, unicode: bool },
Bytes(&'a [u8]),
Int(&'a ast::Int),
Tuple(Vec<ComparableConstant<'a>>),
Float(u64),
Complex { real: u64, imag: u64 },
Ellipsis,
Expand Down
2 changes: 1 addition & 1 deletion crates/ruff_workspace/src/options.rs
Original file line number Diff line number Diff line change
Expand Up @@ -2392,7 +2392,7 @@ pub struct PylintOptions {
/// Constant types to ignore when used as "magic values" (see: `PLR2004`).
#[option(
default = r#"["str", "bytes"]"#,
value_type = r#"list["str" | "bytes" | "complex" | "float" | "int" | "tuple"]"#,
value_type = r#"list["str" | "bytes" | "complex" | "float" | "int"]"#,
example = r#"
allow-magic-value-types = ["int"]
"#
Expand Down
3 changes: 1 addition & 2 deletions ruff.schema.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit ec1be60

Please sign in to comment.