Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[T10]: Feature Request: Add checks for debugpy and ptvsd imports #10177

Closed
ivanbarsukov opened this issue Mar 1, 2024 · 2 comments
Closed

[T10]: Feature Request: Add checks for debugpy and ptvsd imports #10177

ivanbarsukov opened this issue Mar 1, 2024 · 2 comments
Labels
good first issue Good for newcomers rule Implementing or modifying a lint rule

Comments

@ivanbarsukov
Copy link

I'm suggesting to enhance T10 rule by adding checks for imports of debugpy and ptvsd, commonly used debugging packages
@charliermarsh charliermarsh added the rule Implementing or modifying a lint rule label Mar 1, 2024
@charliermarsh
Copy link
Member

Sounds reasonable to me.

@charliermarsh charliermarsh added the good first issue Good for newcomers label Mar 1, 2024
jeremy-hiatt added a commit to jeremy-hiatt/ruff that referenced this issue Mar 2, 2024
@jeremy-hiatt
Check for use of debugpy and ptvsd debug modules (astral-sh#10177)
21ebf18 
This addresses astral-sh#10177.

I added additional lines to the existing test file for T100.
@jeremy-hiatt jeremy-hiatt mentioned this issue Mar 2, 2024
Merged
jeremy-hiatt added a commit to jeremy-hiatt/ruff that referenced this issue Mar 2, 2024
@jeremy-hiatt
Check for use of debugpy and ptvsd debug modules (astral-sh#10177)
cc56dd2
charliermarsh pushed a commit that referenced this issue Mar 2, 2024
@jeremy-hiatt
Check for use of debugpy and ptvsd debug modules (#10177) (#10194)
c007b17 
## Summary

This addresses #10177.

## Test Plan

I added additional lines to the existing test file for T100.
@charliermarsh
Copy link
Member

Closed by #10194 thanks to @jeremy-hiatt!

nkxxll pushed a commit to nkxxll/ruff that referenced this issue Mar 10, 2024
@jeremy-hiatt @nkxxll
Check for use of debugpy and ptvsd debug modules (astral-sh#10177) (
8eb5a16 
astral-sh#10194)

## Summary

This addresses astral-sh#10177.

## Test Plan

I added additional lines to the existing test file for T100.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers rule Implementing or modifying a lint rule
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@charliermarsh @ivanbarsukov