Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nan-comparison code mismatch with Pylint #10791

Closed
BlindChickens opened this issue Apr 5, 2024 · 5 comments · Fixed by #10894
Closed

nan-comparison code mismatch with Pylint #10791

BlindChickens opened this issue Apr 5, 2024 · 5 comments · Fixed by #10894
Assignees
@charliermarsh
Labels
bug Something isn't working rule Implementing or modifying a lint rule

Comments

@BlindChickens
Copy link

In the (W)arning category of Pylint nan-comparison has code W0177. Here

In Ruff it is coded to W0117.

Is it a mistake?

Thanks in advance
@charliermarsh charliermarsh added bug Something isn't working rule Implementing or modifying a lint rule labels Apr 7, 2024
@charliermarsh
Copy link
Member

Ahh thank you! We'll correct it. Looks like an oversight.

@WindowGenerator
Copy link
Contributor

@charliermarsh Hi!
Can I fix it?

@charliermarsh
Copy link
Member

Feel free, thanks! You'll need to update the code in codes.rs, and then also add a redirect from the old to new code in rule_redirects.rs.

@charliermarsh
Copy link
Member

I'm gonna go ahead and fix this real quick.

@charliermarsh charliermarsh self-assigned this Apr 12, 2024
@charliermarsh charliermarsh mentioned this issue Apr 12, 2024
Merged
charliermarsh added a commit that referenced this issue Apr 12, 2024
@charliermarsh
[pylint] Recode nan-comparison rule to W0177 (#10894)
312f434 
## Summary

This was accidentally committed under `W0117`, but the actual Pylint
code is `W0177`:
https://pylint.readthedocs.io/en/latest/user_guide/checkers/features.html.

Closes #10791.
Glyphack pushed a commit to Glyphack/ruff that referenced this issue Apr 12, 2024
@charliermarsh @Glyphack
[pylint] Recode nan-comparison rule to W0177 (astral-sh#10894)
2e5fcfe 
## Summary

This was accidentally committed under `W0117`, but the actual Pylint
code is `W0177`:
https://pylint.readthedocs.io/en/latest/user_guide/checkers/features.html.

Closes astral-sh#10791.
@BlindChickens
Copy link
Author

@charliermarsh
Sorry to necropost like this. But I forgot to ask that this issue be updated to reflect this fix.
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@charliermarsh charliermarsh

Labels
bug Something isn't working rule Implementing or modifying a lint rule
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[pylint] Recode nan-comparison rule to W0177 astral-sh/ruff
3 participants
@charliermarsh @BlindChickens @WindowGenerator