Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[red-knot] support typing.TYPE_CHECKING #14170

Closed
carljm opened this issue Nov 7, 2024 · 1 comment
Closed

[red-knot] support typing.TYPE_CHECKING #14170

carljm opened this issue Nov 7, 2024 · 1 comment
Assignees
@sharkdp
Labels
red-knot Multi-file analysis & type inference
Milestone
Red Knot 2024

Comments

@carljm
Copy link
Contributor

carljm commented Nov 7, 2024

Supporting the symbol itself should be quite easy, the trickier part of this is just #12700
@carljm carljm added the red-knot Multi-file analysis & type inference label Nov 7, 2024
@carljm carljm added this to the Red Knot 2024 milestone Nov 7, 2024
@sharkdp sharkdp self-assigned this Nov 28, 2024
This was referenced Dec 9, 2024
Closed
Merged
sharkdp added a commit that referenced this issue Dec 13, 2024
@sharkdp
[red-knot] Support typing.TYPE_CHECKING (#14952)
e96b13c 
## Summary

Add support for `typing.TYPE_CHECKING` and
`typing_extensions.TYPE_CHECKING`.

relates to: #14170

## Test Plan

New Markdown-based tests
@AlexWaygood
Copy link
Member

I think we can close this as "completed" now that #14952 has landed. The only parts of this left to do are entirely covered by #12700

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sharkdp sharkdp

Labels
red-knot Multi-file analysis & type inference
Projects
None yet
Milestone
Red Knot 2024
Development

Successfully merging a pull request may close this issue.

[red-knot] Statically known branches (first take) astral-sh/ruff
3 participants
@carljm @sharkdp @AlexWaygood