Suppress PTH* family of rules if `dir_fd=` is passed

[septatrix]

Summary

dir_fd can be used to operate on a file relative to a pinned directory descriptor. This is useful to prevent bugs, most importantly race conditions. The respective functionality is not available in pathlib and the suggestion to use the respective Path methods therefore does not make sense

$ ruff check --select=PTH test.py
test.py:1:1: PTH123 `open()` should be replaced by `Path.open()`
  |
1 | open("test.txt", dir_fd=1)
  | ^^^^ PTH123
  |

Found 1 error.

Version

ruff 0.11.5

[septatrix]

Ideally the same would apply when the path argument is a fd but that would require type information to correctly check which is not available to ruff, a compromise could be to allow number literals (and maybe some variable names like fd) but that seems quite hacky

[ntBre]

I thought we took care of these in #17968, which should have been released with 0.11.10. Could you try with a more recent Ruff version?

[ntBre]

We do avoid a diagnostic for PTH123 when path is a file descriptor (playground), but in this specific example you're still getting a diagnostic because dir_fd isn't a known argument to open.

I think we properly handle path in other cases too, at least the few I tried.

[septatrix]

I thought we took care of these in #17968, which should have been released with 0.11.10. Could you try with a more recent Ruff version?

Ah yes with a newer version it works as expected (I also had to change open to os.open in the reproduction because only the latter supports dir_fd=)

[ntBre]

Good to hear! If you find any cases where it's not updated, please open another issue!