-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Description
@ntBre pointed out in #19362 that mkdocs-material was likely lagging behind the latest version. I tried to find out why this dependency wasn't automatically updated and found that 2 dependencies used by the docs build are sha-pinned which renovate doesn't seem to (know how to) update. As renovate seems to be used widely, there might be a false sense of "everything is always kept up to date" so I thought I make an issue to document the status quo which is likely not the ideal state.
These 2 dependencies aren't updated by renovate:
ruff/docs/requirements-insiders.txt
Line 4 in c0d04f2
| mkdocs-material @ git+ssh://git@github.com/astral-sh/mkdocs-material-insiders.git@39da7a5e761410349e9a1b8abf593b0cdd5453ff |
ruff/docs/requirements-insiders.txt
Line 8 in c0d04f2
| mkdocs-github-admonitions-plugin @ git+https://github.com/PGijsbers/admonitions.git#7343d2f4a92e4d1491094530ef3d0d02d93afbb7 |
I've noticed that astral-sh's fork of mkdocs-material-insiders is not public/OSS (@ntBre is this on purpose? It makes it hard for outsiders to investigate docs related stuff but that might be a conscious decision) this seems to be due to sponsorship/licensing reasons as I learned in CONTRIBUTING.md:
Lines 282 to 287 in a0d4e1f
| # For contributors. | |
| uvx --with-requirements docs/requirements.txt -- mkdocs serve -f mkdocs.public.yml | |
| # For members of the Astral org, which has access to MkDocs Insiders via sponsorship. | |
| uvx --with-requirements docs/requirements-insiders.txt -- mkdocs serve -f mkdocs.insiders.yml | |
| ``` |
I'm not sure why an ssh pin is used for the public dependency: https://github.com/PGijsbers/admonitions - there's no comment in the requirements.txt. It could be pip-installed: python -m pip install mkdocs-github-admonitions-plugin and hence added to requirements.txt AFAICT