Format assignment expressions (FormatExprNamedExpr)

[konstin]

Assignment expressions are those using the "walrus operator" :=:

if x := f():
    g(x)

In general, they are easy to format, they are a sequence of target, space, :=, space, value with optional parentheses.

The difficulty is that there are a list of exceptional cases in PEP 572 where the parentheses are mandatory based on the surrounding node, e.g. keyword argument values need parentheses. So for implementing this we either need to use the tuple way of checking if there are parentheses in range or each node in the list in PEP 572 needs to have a special case where it checks whether the expression it is about to format is a ExprNamedExpr and in that cases sets the parentheses to always.

[charliermarsh]

If the named expression needs to be parenthesized, won’t it already have been parenthesized in the parsed source? (Otherwise it would’ve been invalid syntax in the first place.) So would those “exceptions” be solved by preserving original parentheses? May be misunderstanding.

[konstin]

Good point, i filed this because i tried the naive solution and failed, but you're right, the tuple way of checking if there are parentheses in range is likely better

[konstin]

Implemented this differently because unlike tuples even mandatory parentheses are not part of the range