Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failed to create fix for UnnecessaryComprehensionAnyAll: Expected Expression::ListComp #6713

Closed
qarmin opened this issue Aug 21, 2023 · 2 comments · Fixed by #6744
Closed

Failed to create fix for UnnecessaryComprehensionAnyAll: Expected Expression::ListComp #6713

qarmin opened this issue Aug 21, 2023 · 2 comments · Fixed by #6744
Labels
bug Something isn't working fixes Related to suggested fixes for violations fuzzer Surfaced via fuzzing.

Comments

@qarmin
Copy link

qarmin commented Aug 21, 2023

Ruff 0.0.285

ruff  *.py --select ALL

file content:

any(x.id for x in bar)
any({x.id for x in bar})

error:

error: Failed to create fix for UnnecessaryComprehensionAnyAll: Expected Expression::ListComp
PY_FILE_TEST_51040573.py:1:1: D100 Missing docstring in public module

PY_FILE_TEST_51040573.py.zip
@dhruvmanila
Copy link
Member

It seems that neither flake8-comprehension or flake8-pie raises a violation when set comprehensions are used. \cc @charliermarsh any idea why this was added in #3824?

Sets are unordered so we might not know when any stops and if it benefits or not. Depending on the reason for the PR, the fix would be either to not flag it for set comprehensions or update the autofix to account for that.

@dhruvmanila dhruvmanila added bug Something isn't working fixes Related to suggested fixes for violations labels Aug 21, 2023
@charliermarsh
Copy link
Member

@dhruvmanila - It still makes sense to avoid allocating the set IMO. We should update the autofix, I think.

@charliermarsh charliermarsh added the fuzzer Surfaced via fuzzing. label Aug 21, 2023
@charliermarsh charliermarsh mentioned this issue Aug 21, 2023
Merged
charliermarsh added a commit that referenced this issue Aug 21, 2023
@charliermarsh
Support C419 autofixes for set comprehensions (#6744)
7650c6e 
Closes #6713.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working fixes Related to suggested fixes for violations fuzzer Surfaced via fuzzing.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support C419 autofixes for set comprehensions astral-sh/ruff
3 participants
@charliermarsh @qarmin @dhruvmanila