Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rule C417 cause autofix error #7121

Closed
qarmin opened this issue Sep 4, 2023 · 0 comments · Fixed by #7189
Closed

Rule C417 cause autofix error #7121

qarmin opened this issue Sep 4, 2023 · 0 comments · Fixed by #7189
Assignees
Labels
bug Something isn't working fuzzer Surfaced via fuzzing.

Comments

@qarmin
Copy link

qarmin commented Sep 4, 2023

Ruff 0.0.287 (latest changes from main branch)

ruff  *.py --select C417 --no-cache --fix

file content(at least simple cpython script shows that this is valid python file):

if cls:
        entries_list_xslt_tree = etree.XSLT(
            entries_list_xslt, extensions={
                ("entries_list_ns", "EntryName"): EntryName})
        entries_list_xslt_tree(self, **dict(zip(
            map(lambda x: etree.XSLT.strparam(str(x)),
                limits if limits is not None else [0x0000, 0xFFFF])
            )))

error

/home/rafal/test/tmp_folder/197731.py:6:13: C417 Unnecessary `map` usage (rewrite using a generator expression)
Found 1 error.

error: Autofix introduced a syntax error. Reverting all changes.

This indicates a bug in `ruff`. If you could open an issue at:

    https://github.com/astral-sh/ruff/issues/new?title=%5BAutofix%20error%5D

...quoting the contents of `/home/rafal/test/tmp_folder/197731.py`, the rule codes C417, along with the `pyproject.toml` settings and executed command, we'd be very appreciative!

python_compressed.zip

@MichaReiser MichaReiser added bug Something isn't working fuzzer Surfaced via fuzzing. labels Sep 4, 2023
@charliermarsh charliermarsh self-assigned this Sep 6, 2023
charliermarsh added a commit that referenced this issue Sep 6, 2023
zanieb pushed a commit that referenced this issue Sep 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fuzzer Surfaced via fuzzing.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants