Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Confusing UP018 fix title #7912

Closed
konstin opened this issue Oct 11, 2023 · 0 comments · Fixed by #7913
Closed

Confusing UP018 fix title #7912

konstin opened this issue Oct 11, 2023 · 0 comments · Fixed by #7913

Comments

@konstin
Copy link
Member

konstin commented Oct 11, 2023 

python_version = str("*")

suggests "Replace with empty string". The fix does the correct thing and removes the superfluous str call, but the message is wrong since this is not an empty string.
@T-256 T-256 mentioned this issue Oct 11, 2023
Merged
konstin pushed a commit that referenced this issue Oct 11, 2023
@T-256
UP018: Improve Fix message (#7913)
a1ee6d2 
<!--
Thank you for contributing to Ruff! To help us out with reviewing,
please consider the following:

- Does this pull request include a summary of the change? (See below.)
- Does this pull request include a descriptive title?
- Does this pull request include references to any relevant issues?
-->

## Summary

<!-- What's the purpose of the change? What does it do, and why? -->
closes #7912

## Test Plan

<!-- How was it tested? -->
konstin pushed a commit that referenced this issue Oct 11, 2023
@T-256 @konstin
UP018: Improve Fix message (#7913)
0782cec 
<!--
Thank you for contributing to Ruff! To help us out with reviewing,
please consider the following:

- Does this pull request include a summary of the change? (See below.)
- Does this pull request include a descriptive title?
- Does this pull request include references to any relevant issues?
-->

## Summary

<!-- What's the purpose of the change? What does it do, and why? -->
closes #7912

## Test Plan

<!-- How was it tested? -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

UP018: Improve Fix message T-256/ruff
1 participant
@konstin