boolean-positional-value-in-call (FBT003) - don't warn when function name starts with set_ and only takes one argument

[DetachHead]

functions like these should not report the error imo, since the meaning of the bool is self explanatory, which is often the case when the functin starts with set_:

def set_enabled(enabled: bool):
    ...

set_enabled(True) # self explanatory
set_enabled(enabled=True) # unnecessary/redundant

[zanieb]

This seems a little bit too specific to me.

[charliermarsh]

We may want to do this, it would also help with #9287 and #3247 (comment).

[tmke8]

Maybe also allow the use_ prefix? I encountered that with torch.use_deterministic_algorithms. The following feels a bit silly:

torch.use_deterministic_algorithms(mode=True)

[charliermarsh]

I'm kind of wondering if we should just avoid calling this on third-party function calls.

[bswck]

I often use flag-holding context vars.

from contextvars import ContextVar

cv = ContextVar("cv", default=False)
cv.set(True)  # triggers FBT003

What a pity the fix for this doesn't apply to ContextVar.set.

[DetachHead]

it looks like the check expects the function name to start with "set" followed by either an underscore or an uppercase character, but not "set" on its own. it should probably be updated to allow that too.

[zanieb]

It seems reasonable to expand it to cover that case.