Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pylint] Implement singledispatchmethod-function (PLE5120) #10428

Merged
merged 2 commits into from
Mar 18, 2024
Merged

[pylint] Implement singledispatchmethod-function (PLE5120) #10428

merged 2 commits into from
Mar 18, 2024

Conversation

augustelalande
Copy link
Contributor

@augustelalande augustelalande commented Mar 15, 2024 •
edited
Loading

Summary

Implement singledispatchmethod-function from pylint, part of #970.

This is essentially a copy paste of #8934 for @singledispatchmethod decorator.

Test Plan

Text fixture added.

@augustelalande augustelalande changed the title [pylint] Add singledispatchmethod-function (PLE5120) [pylint] Implement singledispatchmethod-function (PLE5120) Mar 15, 2024
@augustelalande augustelalande force-pushed the singledispatchmethod-function branch from 9ab497d to 7c6b67d Compare March 15, 2024 23:05
@augustelalande augustelalande force-pushed the singledispatchmethod-function branch from 7c6b67d to 5d09a08 Compare March 15, 2024 23:13
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 15, 2024 •
edited
Loading

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

Formatter (stable)

✅ ecosystem check detected no format changes.

Formatter (preview)

✅ ecosystem check detected no format changes.

@charliermarsh charliermarsh self-requested a review March 17, 2024 21:29
@charliermarsh charliermarsh added rule Implementing or modifying a lint rule preview Related to preview mode features labels Mar 17, 2024
charliermarsh
charliermarsh approved these changes Mar 17, 2024
View reviewed changes
Copy link
Member

@charliermarsh charliermarsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@charliermarsh charliermarsh enabled auto-merge (squash) March 17, 2024 23:56
@charliermarsh charliermarsh merged commit 229a50a into astral-sh:main Mar 18, 2024
17 checks passed
@augustelalande augustelalande deleted the singledispatchmethod-function branch March 18, 2024 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charliermarsh charliermarsh charliermarsh approved these changes

Assignees
No one assigned
Labels
preview Related to preview mode features rule Implementing or modifying a lint rule
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@augustelalande @charliermarsh