[Pylint
] Fixed false-positive on the rule PLW1641
(eq-without-hash
)
#10566
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixed false-positive on the rule
PLW1641
, where the explicit assignment on the__hash__
method is not counted as an definition of__hash__
. (Discussed in #10557).Also, added one new testcase.
Test Plan
Checked on
cargo test
ineq_without_hash.py
.Before the change, for the assignment into
__hash__
, only__hash__ = None
was counted as an explicit definition of__hash__
method.Probably any assignment into
__hash__
property could be counted as an explicit definition of hash, so I removedvalue.is_none_literal_expr()
check.