Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[flake8_comprehensions] update docs for unnecessary-comprehension-any-all (C419) #10744

Merged
merged 4 commits into from
Apr 2, 2024

Conversation

carljm
Copy link
Contributor

@carljm carljm commented Apr 2, 2024

Ref #3259; see in particular #3259 (comment)

Summary

Improve the accuracy of the docs for this lint rule/fix.

Test Plan

Generated the docs locally and visited the page for this rule:

Screenshot 2024-04-02 at 4 56 40 PM

Co-authored-by: Zanie Blue <contact@zanie.dev>
@zanieb zanieb added the documentation Improvements or additions to documentation label Apr 2, 2024
@zanieb
Copy link
Member

zanieb commented Apr 2, 2024

We use pull request labels for sorting changelog entries. Feel free to push branches to astral-sh/ruff if you want; we usually prefix with initials or name e.g. zb/foo.

Co-authored-by: Zanie Blue <contact@zanie.dev>
Copy link
Contributor

github-actions bot commented Apr 2, 2024

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

@carljm carljm merged commit 814b26f into astral-sh:main Apr 2, 2024
17 checks passed
@carljm carljm deleted the fewercomps branch April 2, 2024 23:43
Glyphack pushed a commit to Glyphack/ruff that referenced this pull request Apr 12, 2024
…-all (C419) (astral-sh#10744)

Ref astral-sh#3259; see in particular
astral-sh#3259 (comment)

## Summary

Improve the accuracy of the docs for this lint rule/fix.

## Test Plan

Generated the docs locally and visited the page for this rule:

![Screenshot 2024-04-02 at 4 56
40 PM](https://github.com/astral-sh/ruff/assets/61586/64f25cf6-edfe-4682-ac8e-7e21b834f5f2)

---------

Co-authored-by: Zanie Blue <contact@zanie.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants