Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove is_current_token_postfix #10855

Merged
merged 1 commit into from
Apr 10, 2024

Conversation

dhruvmanila
Copy link
Member

Summary

This PR removes the is_current_token_postifx method and instead directly calls the parse_postifx_expression. The condition was required because postfix expression parsing would reset the is_parenthesized field on the ParsedExpr. Now, we'll make that explicit.

@dhruvmanila dhruvmanila added the parser Related to the parser label Apr 10, 2024
@dhruvmanila dhruvmanila merged commit fc3c314 into dhruv/parser Apr 10, 2024
5 checks passed
@dhruvmanila dhruvmanila deleted the dhruv/remove-is-current-postfix branch April 10, 2024 04:18
Copy link

codspeed-hq bot commented Apr 10, 2024

CodSpeed Performance Report

Merging #10855 will degrade performances by 5.78%

Comparing dhruv/remove-is-current-postfix (a0dc22a) with dhruv/parser (38d649c)

Summary

⚡ 2 improvements
❌ 1 regressions
✅ 27 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark dhruv/parser dhruv/remove-is-current-postfix Change
parser[large/dataset.py] 28.7 ms 26.7 ms +7.66%
parser[pydantic/types.py] 11.8 ms 10.9 ms +8.19%
parser[unicode/pypinyin.py] 1.6 ms 1.7 ms -5.78%

Copy link
Contributor

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

Formatter (stable)

✅ ecosystem check detected no format changes.

Formatter (preview)

✅ ecosystem check detected no format changes.

dhruvmanila added a commit that referenced this pull request Apr 11, 2024
## Summary

This PR removes the `is_current_token_postifx` method and instead
directly calls the `parse_postifx_expression`. The condition was
required because postfix expression parsing would reset the
`is_parenthesized` field on the `ParsedExpr`. Now, we'll make that
explicit.
dhruvmanila added a commit that referenced this pull request Apr 15, 2024
## Summary

This PR removes the `is_current_token_postifx` method and instead
directly calls the `parse_postifx_expression`. The condition was
required because postfix expression parsing would reset the
`is_parenthesized` field on the `ParsedExpr`. Now, we'll make that
explicit.
dhruvmanila added a commit that referenced this pull request Apr 16, 2024
## Summary

This PR removes the `is_current_token_postifx` method and instead
directly calls the `parse_postifx_expression`. The condition was
required because postfix expression parsing would reset the
`is_parenthesized` field on the `ParsedExpr`. Now, we'll make that
explicit.
dhruvmanila added a commit that referenced this pull request Apr 16, 2024
## Summary

This PR removes the `is_current_token_postifx` method and instead
directly calls the `parse_postifx_expression`. The condition was
required because postfix expression parsing would reset the
`is_parenthesized` field on the `ParsedExpr`. Now, we'll make that
explicit.
dhruvmanila added a commit that referenced this pull request Apr 17, 2024
## Summary

This PR removes the `is_current_token_postifx` method and instead
directly calls the `parse_postifx_expression`. The condition was
required because postfix expression parsing would reset the
`is_parenthesized` field on the `ParsedExpr`. Now, we'll make that
explicit.
dhruvmanila added a commit that referenced this pull request Apr 18, 2024
## Summary

This PR removes the `is_current_token_postifx` method and instead
directly calls the `parse_postifx_expression`. The condition was
required because postfix expression parsing would reset the
`is_parenthesized` field on the `ParsedExpr`. Now, we'll make that
explicit.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
parser Related to the parser
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant