[flake8-pyi] Implement PYI066
#11541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tusharsadhwani
commented
May 25, 2024
| /// | ||
| /// if sys.version_info < (3, 10): | ||
| /// | ||
| /// def read_data(x, *, preserve_order=True): |
There was a problem hiding this comment.
I don't think this formatting is the best, but the mkdocs check is failing if I change this in any way.
There was a problem hiding this comment.
I opened #11568 to track this; I've also bumped into this in the past :-)
There was a problem hiding this comment.
feel free to revert the last commit to format it correctly as needed.
|
|
I can merge this one too. |
charliermarsh
added
rule
charliermarsh
changed the title
flake8-pyi] Implement PYI066
|
Thanks @tusharsadhwani! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Y066fromflake8-pyiasPYI066PYI006not being raised forelifclauses. This would have conflicted with PYI006's implementation, so decided to do it in the same PR.Test Plan
cargo test/cargo insta review