Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated top-level lint settings #12009

Closed

Conversation

MichaReiser
Copy link
Member

@MichaReiser MichaReiser commented Jun 24, 2024

Summary

This PR removes the top-level lint settings in favor of the lint.* settings.

The top-level settings were deprecated when Ruff formatter was released in October 2023.

Part of #7650

Test Plan

Verified the updated integration tests taht show, that the top-level settings are no longer accepted.

@MichaReiser MichaReiser added this to the v0.5.0 milestone Jun 24, 2024
@MichaReiser MichaReiser changed the base branch from main to ruff-0.5 June 24, 2024 08:17
@MichaReiser MichaReiser force-pushed the remove-deprecated-top-level-lint-settings branch from 6f9f694 to 0d38ea3 Compare June 24, 2024 08:24
@MichaReiser MichaReiser added breaking Breaking API change configuration Related to settings and configuration cli Related to the command-line interface labels Jun 24, 2024
Copy link
Contributor

ruff-ecosystem results

Linter (stable)

ℹ️ ecosystem check encountered linter errors. (no lint changes; 12 project errors)

PostHog/HouseWatch (error)

ruff failed
  Cause: Failed to parse /home/runner/work/ruff/ruff/checkouts/PostHog:HouseWatch/pyproject.toml
  Cause: TOML parse error at line 16, column 1
   |
16 | select = [
   | ^^^^^^
unknown field `select`, expected one of `cache-dir`, `extend`, `output-format`, `fix`, `unsafe-fixes`, `fix-only`, `show-source`, `show-fixes`, `required-version`, `preview`, `exclude`, `extend-exclude`, `extend-include`, `force-exclude`, `include`, `respect-gitignore`, `builtins`, `namespace-packages`, `target-version`, `src`, `line-length`, `indent-width`, `tab-size`, `lint`, `format`

RasaHQ/rasa (error)

ruff failed
  Cause: Failed to parse /home/runner/work/ruff/ruff/checkouts/RasaHQ:rasa/pyproject.toml
  Cause: TOML parse error at line 348, column 1
    |
348 | ignore = [
    | ^^^^^^
unknown field `ignore`, expected one of `cache-dir`, `extend`, `output-format`, `fix`, `unsafe-fixes`, `fix-only`, `show-source`, `show-fixes`, `required-version`, `preview`, `exclude`, `extend-exclude`, `extend-include`, `force-exclude`, `include`, `respect-gitignore`, `builtins`, `namespace-packages`, `target-version`, `src`, `line-length`, `indent-width`, `tab-size`, `lint`, `format`

aiven/aiven-client (error)

ruff failed
  Cause: Failed to parse /home/runner/work/ruff/ruff/checkouts/aiven:aiven-client/pyproject.toml
  Cause: TOML parse error at line 95, column 1
   |
95 | extend-select = [
   | ^^^^^^^^^^^^^
unknown field `extend-select`, expected one of `cache-dir`, `extend`, `output-format`, `fix`, `unsafe-fixes`, `fix-only`, `show-source`, `show-fixes`, `required-version`, `preview`, `exclude`, `extend-exclude`, `extend-include`, `force-exclude`, `include`, `respect-gitignore`, `builtins`, `namespace-packages`, `target-version`, `src`, `line-length`, `indent-width`, `tab-size`, `lint`, `format`

bloomberg/pytest-memray (error)

ruff failed
  Cause: Failed to parse /home/runner/work/ruff/ruff/checkouts/bloomberg:pytest-memray/pyproject.toml
  Cause: TOML parse error at line 157, column 1
    |
157 | ignore = [
    | ^^^^^^
unknown field `ignore`, expected one of `cache-dir`, `extend`, `output-format`, `fix`, `unsafe-fixes`, `fix-only`, `show-source`, `show-fixes`, `required-version`, `preview`, `exclude`, `extend-exclude`, `extend-include`, `force-exclude`, `include`, `respect-gitignore`, `builtins`, `namespace-packages`, `target-version`, `src`, `line-length`, `indent-width`, `tab-size`, `lint`, `format`

bokeh/bokeh (error)

ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --no-preview --select ALL

ruff failed
  Cause: Failed to parse /home/runner/work/ruff/ruff/checkouts/bokeh:bokeh/pyproject.toml
  Cause: TOML parse error at line 236, column 1
    |
236 | select = [
    | ^^^^^^
unknown field `select`, expected one of `cache-dir`, `extend`, `output-format`, `fix`, `unsafe-fixes`, `fix-only`, `show-source`, `show-fixes`, `required-version`, `preview`, `exclude`, `extend-exclude`, `extend-include`, `force-exclude`, `include`, `respect-gitignore`, `builtins`, `namespace-packages`, `target-version`, `src`, `line-length`, `indent-width`, `tab-size`, `lint`, `format`

demisto/content (error)

ruff failed
  Cause: Failed to parse /home/runner/work/ruff/ruff/checkouts/demisto:content/pyproject.toml
  Cause: TOML parse error at line 93, column 1
   |
93 | select = [
   | ^^^^^^
unknown field `select`, expected one of `cache-dir`, `extend`, `output-format`, `fix`, `unsafe-fixes`, `fix-only`, `show-source`, `show-fixes`, `required-version`, `preview`, `exclude`, `extend-exclude`, `extend-include`, `force-exclude`, `include`, `respect-gitignore`, `builtins`, `namespace-packages`, `target-version`, `src`, `line-length`, `indent-width`, `tab-size`, `lint`, `format`

docker/docker-py (error)

ruff failed
  Cause: Failed to parse /home/runner/work/ruff/ruff/checkouts/docker:docker-py/pyproject.toml
  Cause: TOML parse error at line 82, column 1
   |
82 | extend-select = [
   | ^^^^^^^^^^^^^
unknown field `extend-select`, expected one of `cache-dir`, `extend`, `output-format`, `fix`, `unsafe-fixes`, `fix-only`, `show-source`, `show-fixes`, `required-version`, `preview`, `exclude`, `extend-exclude`, `extend-include`, `force-exclude`, `include`, `respect-gitignore`, `builtins`, `namespace-packages`, `target-version`, `src`, `line-length`, `indent-width`, `tab-size`, `lint`, `format`

freedomofpress/securedrop (error)

ruff failed
  Cause: Failed to parse /home/runner/work/ruff/ruff/checkouts/freedomofpress:securedrop/pyproject.toml
  Cause: TOML parse error at line 13, column 1
   |
13 | select = [
   | ^^^^^^
unknown field `select`, expected one of `cache-dir`, `extend`, `output-format`, `fix`, `unsafe-fixes`, `fix-only`, `show-source`, `show-fixes`, `required-version`, `preview`, `exclude`, `extend-exclude`, `extend-include`, `force-exclude`, `include`, `respect-gitignore`, `builtins`, `namespace-packages`, `target-version`, `src`, `line-length`, `indent-width`, `tab-size`, `lint`, `format`

jrnl-org/jrnl (error)

ruff failed
  Cause: Failed to parse /home/runner/work/ruff/ruff/checkouts/jrnl-org:jrnl/pyproject.toml
  Cause: TOML parse error at line 131, column 1
    |
131 | select = [
    | ^^^^^^
unknown field `select`, expected one of `cache-dir`, `extend`, `output-format`, `fix`, `unsafe-fixes`, `fix-only`, `show-source`, `show-fixes`, `required-version`, `preview`, `exclude`, `extend-exclude`, `extend-include`, `force-exclude`, `include`, `respect-gitignore`, `builtins`, `namespace-packages`, `target-version`, `src`, `line-length`, `indent-width`, `tab-size`, `lint`, `format`

latchbio/latch (error)

ruff failed
  Cause: Failed to parse /home/runner/work/ruff/ruff/checkouts/latchbio:latch/pyproject.toml
  Cause: TOML parse error at line 20, column 1
   |
20 | extend-select = [
   | ^^^^^^^^^^^^^
unknown field `extend-select`, expected one of `cache-dir`, `extend`, `output-format`, `fix`, `unsafe-fixes`, `fix-only`, `show-source`, `show-fixes`, `required-version`, `preview`, `exclude`, `extend-exclude`, `extend-include`, `force-exclude`, `include`, `respect-gitignore`, `builtins`, `namespace-packages`, `target-version`, `src`, `line-length`, `indent-width`, `tab-size`, `lint`, `format`

model-bakers/model_bakery (error)

ruff failed
  Cause: Failed to parse /home/runner/work/ruff/ruff/checkouts/model-bakers:model_bakery/pyproject.toml
  Cause: TOML parse error at line 105, column 1
    |
105 | select = [
    | ^^^^^^
unknown field `select`, expected one of `cache-dir`, `extend`, `output-format`, `fix`, `unsafe-fixes`, `fix-only`, `show-source`, `show-fixes`, `required-version`, `preview`, `exclude`, `extend-exclude`, `extend-include`, `force-exclude`, `include`, `respect-gitignore`, `builtins`, `namespace-packages`, `target-version`, `src`, `line-length`, `indent-width`, `tab-size`, `lint`, `format`

mesonbuild/meson-python (error)

ruff failed
  Cause: Failed to parse /home/runner/work/ruff/ruff/checkouts/mesonbuild:meson-python/pyproject.toml
  Cause: TOML parse error at line 82, column 1
   |
82 | extend-ignore = [
   | ^^^^^^^^^^^^^
unknown field `extend-ignore`, expected one of `cache-dir`, `extend`, `output-format`, `fix`, `unsafe-fixes`, `fix-only`, `show-source`, `show-fixes`, `required-version`, `preview`, `exclude`, `extend-exclude`, `extend-include`, `force-exclude`, `include`, `respect-gitignore`, `builtins`, `namespace-packages`, `target-version`, `src`, `line-length`, `indent-width`, `tab-size`, `lint`, `format`

Linter (preview)

ℹ️ ecosystem check encountered linter errors. (no lint changes; 12 project errors)

PostHog/HouseWatch (error)

ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview

ruff failed
  Cause: Failed to parse /home/runner/work/ruff/ruff/checkouts/PostHog:HouseWatch/pyproject.toml
  Cause: TOML parse error at line 16, column 1
   |
16 | select = [
   | ^^^^^^
unknown field `select`, expected one of `cache-dir`, `extend`, `output-format`, `fix`, `unsafe-fixes`, `fix-only`, `show-source`, `show-fixes`, `required-version`, `preview`, `exclude`, `extend-exclude`, `extend-include`, `force-exclude`, `include`, `respect-gitignore`, `builtins`, `namespace-packages`, `target-version`, `src`, `line-length`, `indent-width`, `tab-size`, `lint`, `format`

RasaHQ/rasa (error)

ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview

ruff failed
  Cause: Failed to parse /home/runner/work/ruff/ruff/checkouts/RasaHQ:rasa/pyproject.toml
  Cause: TOML parse error at line 348, column 1
    |
348 | ignore = [
    | ^^^^^^
unknown field `ignore`, expected one of `cache-dir`, `extend`, `output-format`, `fix`, `unsafe-fixes`, `fix-only`, `show-source`, `show-fixes`, `required-version`, `preview`, `exclude`, `extend-exclude`, `extend-include`, `force-exclude`, `include`, `respect-gitignore`, `builtins`, `namespace-packages`, `target-version`, `src`, `line-length`, `indent-width`, `tab-size`, `lint`, `format`

aiven/aiven-client (error)

ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview

ruff failed
  Cause: Failed to parse /home/runner/work/ruff/ruff/checkouts/aiven:aiven-client/pyproject.toml
  Cause: TOML parse error at line 95, column 1
   |
95 | extend-select = [
   | ^^^^^^^^^^^^^
unknown field `extend-select`, expected one of `cache-dir`, `extend`, `output-format`, `fix`, `unsafe-fixes`, `fix-only`, `show-source`, `show-fixes`, `required-version`, `preview`, `exclude`, `extend-exclude`, `extend-include`, `force-exclude`, `include`, `respect-gitignore`, `builtins`, `namespace-packages`, `target-version`, `src`, `line-length`, `indent-width`, `tab-size`, `lint`, `format`

bloomberg/pytest-memray (error)

ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview

ruff failed
  Cause: Failed to parse /home/runner/work/ruff/ruff/checkouts/bloomberg:pytest-memray/pyproject.toml
  Cause: TOML parse error at line 157, column 1
    |
157 | ignore = [
    | ^^^^^^
unknown field `ignore`, expected one of `cache-dir`, `extend`, `output-format`, `fix`, `unsafe-fixes`, `fix-only`, `show-source`, `show-fixes`, `required-version`, `preview`, `exclude`, `extend-exclude`, `extend-include`, `force-exclude`, `include`, `respect-gitignore`, `builtins`, `namespace-packages`, `target-version`, `src`, `line-length`, `indent-width`, `tab-size`, `lint`, `format`

bokeh/bokeh (error)

ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview --select ALL

ruff failed
  Cause: Failed to parse /home/runner/work/ruff/ruff/checkouts/bokeh:bokeh/pyproject.toml
  Cause: TOML parse error at line 236, column 1
    |
236 | select = [
    | ^^^^^^
unknown field `select`, expected one of `cache-dir`, `extend`, `output-format`, `fix`, `unsafe-fixes`, `fix-only`, `show-source`, `show-fixes`, `required-version`, `preview`, `exclude`, `extend-exclude`, `extend-include`, `force-exclude`, `include`, `respect-gitignore`, `builtins`, `namespace-packages`, `target-version`, `src`, `line-length`, `indent-width`, `tab-size`, `lint`, `format`

demisto/content (error)

ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview

ruff failed
  Cause: Failed to parse /home/runner/work/ruff/ruff/checkouts/demisto:content/pyproject.toml
  Cause: TOML parse error at line 93, column 1
   |
93 | select = [
   | ^^^^^^
unknown field `select`, expected one of `cache-dir`, `extend`, `output-format`, `fix`, `unsafe-fixes`, `fix-only`, `show-source`, `show-fixes`, `required-version`, `preview`, `exclude`, `extend-exclude`, `extend-include`, `force-exclude`, `include`, `respect-gitignore`, `builtins`, `namespace-packages`, `target-version`, `src`, `line-length`, `indent-width`, `tab-size`, `lint`, `format`

docker/docker-py (error)

ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview

ruff failed
  Cause: Failed to parse /home/runner/work/ruff/ruff/checkouts/docker:docker-py/pyproject.toml
  Cause: TOML parse error at line 82, column 1
   |
82 | extend-select = [
   | ^^^^^^^^^^^^^
unknown field `extend-select`, expected one of `cache-dir`, `extend`, `output-format`, `fix`, `unsafe-fixes`, `fix-only`, `show-source`, `show-fixes`, `required-version`, `preview`, `exclude`, `extend-exclude`, `extend-include`, `force-exclude`, `include`, `respect-gitignore`, `builtins`, `namespace-packages`, `target-version`, `src`, `line-length`, `indent-width`, `tab-size`, `lint`, `format`

freedomofpress/securedrop (error)

ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview

ruff failed
  Cause: Failed to parse /home/runner/work/ruff/ruff/checkouts/freedomofpress:securedrop/pyproject.toml
  Cause: TOML parse error at line 13, column 1
   |
13 | select = [
   | ^^^^^^
unknown field `select`, expected one of `cache-dir`, `extend`, `output-format`, `fix`, `unsafe-fixes`, `fix-only`, `show-source`, `show-fixes`, `required-version`, `preview`, `exclude`, `extend-exclude`, `extend-include`, `force-exclude`, `include`, `respect-gitignore`, `builtins`, `namespace-packages`, `target-version`, `src`, `line-length`, `indent-width`, `tab-size`, `lint`, `format`

jrnl-org/jrnl (error)

ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview

ruff failed
  Cause: Failed to parse /home/runner/work/ruff/ruff/checkouts/jrnl-org:jrnl/pyproject.toml
  Cause: TOML parse error at line 131, column 1
    |
131 | select = [
    | ^^^^^^
unknown field `select`, expected one of `cache-dir`, `extend`, `output-format`, `fix`, `unsafe-fixes`, `fix-only`, `show-source`, `show-fixes`, `required-version`, `preview`, `exclude`, `extend-exclude`, `extend-include`, `force-exclude`, `include`, `respect-gitignore`, `builtins`, `namespace-packages`, `target-version`, `src`, `line-length`, `indent-width`, `tab-size`, `lint`, `format`

latchbio/latch (error)

ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview

ruff failed
  Cause: Failed to parse /home/runner/work/ruff/ruff/checkouts/latchbio:latch/pyproject.toml
  Cause: TOML parse error at line 20, column 1
   |
20 | extend-select = [
   | ^^^^^^^^^^^^^
unknown field `extend-select`, expected one of `cache-dir`, `extend`, `output-format`, `fix`, `unsafe-fixes`, `fix-only`, `show-source`, `show-fixes`, `required-version`, `preview`, `exclude`, `extend-exclude`, `extend-include`, `force-exclude`, `include`, `respect-gitignore`, `builtins`, `namespace-packages`, `target-version`, `src`, `line-length`, `indent-width`, `tab-size`, `lint`, `format`

model-bakers/model_bakery (error)

ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview

ruff failed
  Cause: Failed to parse /home/runner/work/ruff/ruff/checkouts/model-bakers:model_bakery/pyproject.toml
  Cause: TOML parse error at line 105, column 1
    |
105 | select = [
    | ^^^^^^
unknown field `select`, expected one of `cache-dir`, `extend`, `output-format`, `fix`, `unsafe-fixes`, `fix-only`, `show-source`, `show-fixes`, `required-version`, `preview`, `exclude`, `extend-exclude`, `extend-include`, `force-exclude`, `include`, `respect-gitignore`, `builtins`, `namespace-packages`, `target-version`, `src`, `line-length`, `indent-width`, `tab-size`, `lint`, `format`

mesonbuild/meson-python (error)

ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview

ruff failed
  Cause: Failed to parse /home/runner/work/ruff/ruff/checkouts/mesonbuild:meson-python/pyproject.toml
  Cause: TOML parse error at line 82, column 1
   |
82 | extend-ignore = [
   | ^^^^^^^^^^^^^
unknown field `extend-ignore`, expected one of `cache-dir`, `extend`, `output-format`, `fix`, `unsafe-fixes`, `fix-only`, `show-source`, `show-fixes`, `required-version`, `preview`, `exclude`, `extend-exclude`, `extend-include`, `force-exclude`, `include`, `respect-gitignore`, `builtins`, `namespace-packages`, `target-version`, `src`, `line-length`, `indent-width`, `tab-size`, `lint`, `format`

@charliermarsh
Copy link
Member

Now having seen the ecosystem checks, I think I'd prefer to leave this for now. It seems like it will cause a lot of churn and pain for users, and it doesn't unlock anything new for us. What do you think?

@MichaReiser
Copy link
Member Author

Yeah this seems to disruptive. We'll need better tooling to support users doing the migration. Closing and deferring until later

@MichaReiser MichaReiser deleted the remove-deprecated-top-level-lint-settings branch August 12, 2024 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Breaking API change cli Related to the command-line interface configuration Related to settings and configuration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants