-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove output format text
and use format full
by default
#12010
Conversation
text
and use format full
by defualttext
and use format full
by default
| | ||
| |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like a bug but it isn't. Or, it is a bug in the test rule that always emits an empty range instead of emitting an actual range.
|
I'm a little worried about making this change when the full format is half-complete (#7352) |
@zanieb what's the part that you're worried about? I think showing the code frame for diagnostics is already an improvement by itself worth shipping and the format name |
It just doesn't feel as useful over the concise output without the fixes being shown (seen feedback from one user about this). Oh well though. |
I personally find the source text in the rust compiler extremely useful. I don't think I ever look at the line number to get context on where I need to fix something. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - it might be nice to have a small test plan :)
7aa60a4
to
9bb1ccc
Compare
I updated the PR to keep the |
9bb1ccc
to
b8d1ba6
Compare
Summary
This PR removes support for the output format
text
in favor ofconcise
and makesfull
the new default (it was already the default for preview mode). TheOutputFormat::Text
is still defined in code so that we can error when it's being used.Resolves #7349
Test Plan
I tested that using
--output-format
on the CLI errors:I verified that using
output-format="text"
in the settings errorsconcise
in the settings or on the CLI works as expectedfull
when nooutput-format
is specified on the CLI or in the settings.