Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use CompactString for Identifier #12101

Merged
merged 4 commits into from
Jul 1, 2024

Use `ruff_python_ast::Name` in `red_knot` crate

43ea86c
Select commit
Loading
Failed to load commit list.
Merged

Use CompactString for Identifier #12101

Use `ruff_python_ast::Name` in `red_knot` crate
43ea86c
Select commit
Loading
Failed to load commit list.
CodSpeed HQ / CodSpeed Performance Analysis succeeded Jul 1, 2024 in 0s

Performance Gate Passed

Summary

⚡ 6 improvements
✅ 24 untouched benchmarks

Benchmarks breakdown

Benchmark main identifier-compact_str Change
⚡ lexer[large/dataset.py] 1.1 ms 1.1 ms +6.06%
⚡ lexer[numpy/ctypeslib.py] 227.2 µs 216.3 µs +5.06%
⚡ lexer[pydantic/types.py] 506.2 µs 481.6 µs +5.11%
⚡ lexer[unicode/pypinyin.py] 77.4 µs 74.2 µs +4.3%
⚡ linter/default-rules[pydantic/types.py] 1.9 ms 1.8 ms +7.54%
⚡ parser[numpy/ctypeslib.py] 953.7 µs 915 µs +4.23%
View more details on CodSpeed HQ