Upgrade RustPython to support parenthesized context managers #1228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charliermarsh
force-pushed
the
charlie/parenthsized-with
branch
from
ceb629f
to
a3f1fe6
Compare
|
I'm pumped for this! |
|
This pushed me to try ruff on phantom-types, and I'm very impressed with it! 🚀 |
|
Rock on! Thank you for giving Ruff a try. Looks like a cool project by the way :) |
|
This says 'Closes #680.' But it only fixes the context managers right? Not structural pattern matching which that issues was originally about. |
|
Yes, although we still have an open issue for that and we only need one. |
|
(Yes, sorry, my mistake.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to @andersk for the fix upstream. We also get much-improved end-locations for functions and classes and other compound statements based on @harupy's work.
Closes #54.
Closes #847.
Closes #680.