Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a new Binding::is_unused method #12729

Merged
merged 1 commit into from
Aug 7, 2024
Merged

Add a new Binding::is_unused method #12729

merged 1 commit into from
Aug 7, 2024

Conversation

AlexWaygood
Copy link
Member

if binding.is_unused() reads more naturally than if !binding.is_used(). We could possibly even get rid of Binding::is_used: with this refactor, it's not used in very many places

Copy link
Contributor

github-actions bot commented Aug 7, 2024

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

Copy link
Member

@MichaReiser MichaReiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@AlexWaygood AlexWaygood merged commit d380b37 into main Aug 7, 2024
20 checks passed
@AlexWaygood AlexWaygood deleted the alex/unused-binding branch August 7, 2024 10:17
dylwil3 pushed a commit to dylwil3/ruff that referenced this pull request Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal An internal refactor or improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants