Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[red-knot] Add debug assert to check for duplicate definitions #13214

Merged
merged 1 commit into from
Sep 4, 2024
Merged

[red-knot] Add debug assert to check for duplicate definitions #13214

merged 1 commit into from
Sep 4, 2024

Conversation

dhruvmanila
Copy link
Member

@dhruvmanila dhruvmanila commented Sep 2, 2024 •
edited
Loading

Summary

Closes: #13085

Test Plan

cargo insta test --workspace

@dhruvmanila dhruvmanila added the red-knot Multi-file analysis & type inference label Sep 2, 2024
@dhruvmanila dhruvmanila marked this pull request as ready for review September 2, 2024 12:52
@AlexWaygood AlexWaygood removed their request for review September 2, 2024 13:42
@dhruvmanila dhruvmanila force-pushed the dhruv/assert-duplicate-definitions branch from d88c0cc to 84b577e Compare September 3, 2024 05:30
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 3, 2024 •
edited
Loading

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

Base automatically changed from dhruv/comprehension-multiple-target to main September 4, 2024 05:49
@dhruvmanila dhruvmanila force-pushed the dhruv/assert-duplicate-definitions branch from 84b577e to e672eff Compare September 4, 2024 05:49
@dhruvmanila dhruvmanila enabled auto-merge (squash) September 4, 2024 05:51
@dhruvmanila dhruvmanila merged commit 862bd0c into main Sep 4, 2024
19 checks passed
@dhruvmanila dhruvmanila deleted the dhruv/assert-duplicate-definitions branch September 4, 2024 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichaReiser MichaReiser MichaReiser approved these changes

@carljm carljm carljm approved these changes

Assignees
No one assigned
Labels
red-knot Multi-file analysis & type inference
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[red-knot] assert that we don't create multiple definitions for one node
3 participants
@dhruvmanila @carljm @MichaReiser