Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create insta snapshot for SARIF output #13345

Merged
merged 1 commit into from
Sep 13, 2024
Merged

Create insta snapshot for SARIF output #13345

merged 1 commit into from
Sep 13, 2024

Conversation

dhruvmanila
Copy link
Member

Summary

Follow-up from #13268, this PR updates the test case to use assert_snapshot now that the output is limited to only include the rules with diagnostics.

Test Plan

cargo insta test

@dhruvmanila dhruvmanila added the internal An internal refactor or improvement label Sep 13, 2024
@dhruvmanila dhruvmanila enabled auto-merge (squash) September 13, 2024 14:27
@dhruvmanila dhruvmanila merged commit 9bd9981 into main Sep 13, 2024
17 checks passed
@dhruvmanila dhruvmanila deleted the dhruv/sarif-snapshot branch September 13, 2024 14:35
@github-actions GitHub Actions
Copy link
Contributor

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

Formatter (stable)

✅ ecosystem check detected no format changes.

Formatter (preview)

✅ ecosystem check detected no format changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichaReiser MichaReiser MichaReiser approved these changes

Assignees
No one assigned
Labels
internal An internal refactor or improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dhruvmanila @MichaReiser