Fix F841 (`UnusedVariable`) range in except handler #1367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

charliermarsh merged 2 commits into astral-sh:main from harupy:fix-F841-location-in-except-handler

Dec 25, 2022

Contributor

harupy commented Dec 25, 2022 •

edited

Loading

Currently, F841 spans the entire except handler, which is undesired. This PR fixes it.

Example

try:
    pass
except ValueError as e:
    pass

Before

a.py:3:1: F841 Local variable `e` is assigned to but never used
  |
3 | / except ValueError as e:
4 | |     pass
  | |________^ F841
  |

After

a.py:3:22: F841 Local variable `e` is assigned to but never used
  |
3 | except ValueError as e:
  |                      ^ F841
  |

harupy added 2 commits

December 25, 2022 12:15


          Fix F841 (UnusedVariable) range

6b41726


          Fix comment

1cc1df8

harupy force-pushed the fix-F841-location-in-except-handler branch from 6c9ce16 to 1cc1df8 Compare

December 25, 2022 03:30

charliermarsh merged commit 10f75c9 into astral-sh:main

Member

charliermarsh commented Dec 25, 2022

Awesome, these range fixes are really impactful.

harupy deleted the fix-F841-location-in-except-handler branch

December 25, 2022 05:05

harupy mentioned this pull request

Improve excepthandler_name_range #1368

Merged

renovate bot referenced this pull request in ixm-one/pytest-cmake-presets


          ⬆️ Update dependency ruff to ^0.0.194 (#5)

30bb652

[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [ruff](https://togithub.com/charliermarsh/ruff) | `^0.0.193` ->
`^0.0.194` |
[![age](https://badges.renovateapi.com/packages/pypi/ruff/0.0.194/age-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://badges.renovateapi.com/packages/pypi/ruff/0.0.194/adoption-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://badges.renovateapi.com/packages/pypi/ruff/0.0.194/compatibility-slim/0.0.193)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://badges.renovateapi.com/packages/pypi/ruff/0.0.194/confidence-slim/0.0.193)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>charliermarsh/ruff</summary>

###
[`v0.0.194`](https://togithub.com/charliermarsh/ruff/releases/tag/v0.0.194)

[Compare
Source](https://togithub.com/charliermarsh/ruff/compare/v0.0.193...v0.0.194)

##### What's Changed

- Fix F841 (`UnusedVariable`) range in except handler by
[@&#8203;harupy](https://togithub.com/harupy) in
[https://github.com/charliermarsh/ruff/pull/1367](https://togithub.com/charliermarsh/ruff/pull/1367)
- Improve `excepthandler_name_range` by
[@&#8203;harupy](https://togithub.com/harupy) in
[https://github.com/charliermarsh/ruff/pull/1368](https://togithub.com/charliermarsh/ruff/pull/1368)
- Ignore unused arguments for
[@&#8203;overload](https://togithub.com/overload) stubs by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[https://github.com/charliermarsh/ruff/pull/1373](https://togithub.com/charliermarsh/ruff/pull/1373)
- Respect natural ordering for imports by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[https://github.com/charliermarsh/ruff/pull/1374](https://togithub.com/charliermarsh/ruff/pull/1374)
- Add a `--fix-only` command-line and `pyproject.toml` option by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[https://github.com/charliermarsh/ruff/pull/1375](https://togithub.com/charliermarsh/ruff/pull/1375)
- Avoid double-extending past the end when showing source by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[https://github.com/charliermarsh/ruff/pull/1377](https://togithub.com/charliermarsh/ruff/pull/1377)
- Add --required-version by
[@&#8203;charliermarsh](https://togithub.com/charliermarsh) in
[https://github.com/charliermarsh/ruff/pull/1376](https://togithub.com/charliermarsh/ruff/pull/1376)

**Full Changelog**:
astral-sh/ruff@v0.0.193...v0.0.194

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://app.renovatebot.com/dashboard#github/ixm-one/pytest-cmake-presets).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC43Mi4zIiwidXBkYXRlZEluVmVyIjoiMzQuNzIuMyJ9-->

Signed-off-by: Renovate Bot <bot@renovateapp.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet