Remove layout values from AnyStringPart
#13681
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaReiser
added
internal
MichaReiser
force-pushed
the
micha/refactor-any-string-part
branch
from
7356e4c to
f903e30
Compare
MichaReiser
commented
Oct 8, 2024
| pub(crate) fn is_multiline(self, source: &str) -> bool { | ||
| match self { | ||
| AnyString::String(_) | AnyString::Bytes(_) => { | ||
| self.parts(Quoting::default()) |
Member
Author
There was a problem hiding this comment.
This is kind of what triggered the refactor. It felt off that it is necessary to pass an arbitrary Quoating to iterate over the parts.
MichaReiser
force-pushed
the
micha/refactor-any-string-part
branch
from
47c1630 to
f903e30
Compare
Contributor
|
MichaReiser
changed the title
AnyStringPart
AlexWaygood
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is a small refactor to simplify
AnyStringPart. I always found it difficult to reason about how thequotingflows through the formattingand this was part due to it being routed to
parts,AnyStringPartand finally itsFormatimplementation.This PR makes
AnyStringParta simple enum over the different parts as it used to be and moves the logic forformatting a part into the
FormatImplicitConcatenatedString, the only place where it is used.Test Plan
cargo test