Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add links to missing related options within rule documentations #13971

Merged
merged 12 commits into from
Nov 3, 2024

Conversation

CarrotManMatt
Copy link
Contributor

No description provided.

Rule "hardcoded-temp-file" (S108) makes use of the option `lint.flake8-bandit.hardcoded-tmp-directory`. This commit adds the link to that option within the rule's documentation.
Rule "incorrectly-parenthesized-tuple-in-subscript" (RUF031) makes use of the option `lint.ruff.parenthesize-tuple-in-subscript`. This commit adds the link to that option within the rule's documentation.
Rule "magic-value-comparison" (PLR2004) makes use of the option `lint.pylint.allow-magic-value-types`. This commit adds the link to that option within the rule's documentation.
Rule "unused-import" (F401) makes use of the option `lint.pyflakes.allowed-unused-imports`. This commit adds the link to that option within the rule's documentation.
@charliermarsh
Copy link
Member

How did you find these?

@CarrotManMatt
Copy link
Contributor Author

Just searching manually. I looked at the settings page and compared which rules from that namespace might be using that settings, then checked that the rule linked to that settings. It would be great to have some more automated way to ensure related settings and rules are linked together.

@MichaReiser MichaReiser added the documentation Improvements or additions to documentation label Oct 29, 2024
@charliermarsh charliermarsh marked this pull request as ready for review November 3, 2024 19:15
@charliermarsh charliermarsh merged commit 3ca2478 into astral-sh:main Nov 3, 2024
20 checks passed
Copy link
Contributor

github-actions bot commented Nov 3, 2024

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants