-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[eradicate
] Better detection of IntelliJ language injection comments (ERA001
)
#14094
Conversation
By the way, do we want that giant regex to be case-insensitive? |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you help me review this more efficiently by listing yoour changes so that I don't have to diff the Regex?
For case-sensitivity: I think we should use case-sensitive for the suppression comments that are case-sensitive and allow case-insensitivity for the ones that are not.
I also think we should gate this change behind preview mode unless all changes relax the rule's strictness.
Here's a comparison table:
As for
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the table. That made reviewing so much easier.
This looks good to me. The main open question is if the change should be gated behind preview. I'm leaning towards no, considering that there are no changes in the ecosystem check. @AlexWaygood are you okay with this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm fine with this. It feels like a bugfix to me and, as you say, the ecosystem report indicates that it shouldn't be that disruptive.
eradicate
] Better detection of IntelliJ language injection comments (ERA001
)
Summary
Enhances #14069.
Test Plan
A few tests are added to cover edge cases.